[issue20069] Add unit test for os.chown

Roundup Robot added the comment: New changeset 4cea99f51bfe by Serhiy Storchaka in branch 'default': Issue #20069: Fixed test_os on Solaris: error message is platform depended. https://hg.python.org/cpython/rev/4cea99f51bfe -- ___ Python tracker

[issue20069] Add unit test for os.chown

Serhiy Storchaka added the comment: Tests failed on Solaris: http://buildbot.python.org/all/builders/AMD64%20Solaris%2011%20%5BSB%5D%203.x/builds/3895/steps/test/logs/stdio == FAIL: test_chown_without_permission (test.test_os.Ch

[issue20069] Add unit test for os.chown

R. David Murray added the comment: Thanks, Vajrasky. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ _

[issue20069] Add unit test for os.chown

Roundup Robot added the comment: New changeset 32c5b9aeee82 by R David Murray in branch 'default': #20069: Add tests for os.chown. https://hg.python.org/cpython/rev/32c5b9aeee82 -- nosy: +python-dev ___ Python tracker

[issue20069] Add unit test for os.chown

Vajrasky Kok added the comment: Here is the latest patch which executes unittest.main inside __main__ based on R. David Murray's review. Thanks! -- Added file: http://bugs.python.org/file37540/add_unit_test_os_chown_v7.patch ___ Python tracker

[issue20069] Add unit test for os.chown

Vajrasky Kok added the comment: Here is the patch based on R. David Murray's review. Thanks! Thanks also for the work of Cormac O'Brien. -- Added file: http://bugs.python.org/file37096/add_unit_test_os_chown_v6.patch ___ Python tracker

[issue20069] Add unit test for os.chown

Cormac O'Brien added the comment: The unit test has changed significantly since R. David Murray posted his suggestions, but I've at least moved the test over to the new format as noted in the last comment of the v5 patch. -- nosy: +cormac-obrien Added file: http://bugs.python.org/file3

[issue20069] Add unit test for os.chown

R. David Murray added the comment: Added a couple review comments on possible further improvements. -- nosy: +r.david.murray ___ Python tracker ___ __

[issue20069] Add unit test for os.chown

Changes by Claudiu Popa : -- nosy: +berker.peksag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue20069] Add unit test for os.chown

Claudiu Popa added the comment: Looks good to me. -- stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list

[issue20069] Add unit test for os.chown

Vajrasky Kok added the comment: Okay, I removed "as _". I thought it was not possible. -- Added file: http://bugs.python.org/file35786/add_unit_test_os_chown_v5.patch ___ Python tracker

[issue20069] Add unit test for os.chown

Claudiu Popa added the comment: Why the need of "as _" in the with statement? I don't understand it. Otherwise, looks good to me. -- ___ Python tracker ___ _

[issue20069] Add unit test for os.chown

Vajrasky Kok added the comment: Claudiu, I have revamped the test and put it in dedicated test class. Thanks! 1. About assertRaisesRegex, sorry, you're right. We can use it with "with" statement. Prior to this, I used it like this: with self.assertRaisesRegex(PermissionError,

[issue20069] Add unit test for os.chown

Changes by Claudiu Popa : -- versions: +Python 3.5 -Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20069] Add unit test for os.chown

Claudiu Popa added the comment: I think you can skip the entire test class if os.chown is not available. Also, maybe you can move the obtaining of groups and users in setUpClass? Also, in +with self.assertRaises(PermissionError) as cx: +os.chown(support.TESTFN, uid_1, gid)

[issue20069] Add unit test for os.chown

Vajrasky Kok added the comment: Here is the patch based on Claudiu's comment and Serhiy's commit (http://hg.python.org/cpython/rev/4b187f5aa960). Claudiu (Thanks!!!), I can not apply two of your suggestions: "You could use support.import_module here in order to skip the test if pwd can't be im

[issue20069] Add unit test for os.chown

Claudiu Popa added the comment: os.chown is not available on Windows. But maybe pwd can't be built on any Unix system, so not using import_module is okay. "=> I can not because assertRaisesRegex can not be used with "with" statement." Not true (see https://docs.python.org/3/library/unittest.h

[issue20069] Add unit test for os.chown

Claudiu Popa added the comment: Hi, I left a couple of comments on rietveld. -- nosy: +Claudiu.Popa ___ Python tracker ___ ___ Python-

[issue20069] Add unit test for os.chown

Vajrasky Kok added the comment: Here is the patch that is considerate towards Windows for Python 3.4. I'll fix the patch for Python 2.7 later. -- Added file: http://bugs.python.org/file34198/add_unit_test_os_chown_v2.patch ___ Python tracker

[issue20069] Add unit test for os.chown

Changes by Vajrasky Kok : Removed file: http://bugs.python.org/file33266/add_unit_test_os_chown.patch ___ Python tracker ___ ___ Python-bugs-l

[issue20069] Add unit test for os.chown

Changes by Ezio Melotti : -- nosy: +ezio.melotti stage: -> patch review type: behavior -> enhancement ___ Python tracker ___ ___ Pyth

[issue20069] Add unit test for os.chown

Vajrasky Kok added the comment: Here is the patch for Python 2.7. -- Added file: http://bugs.python.org/file33267/add_unit_test_os_chown_python27.patch ___ Python tracker ___ __

[issue20069] Add unit test for os.chown

New submission from Vajrasky Kok: There is no tests for os.chown except for the invalid input. Attached the patch to add tests for os.chown. This test has not exercised the keyword `dir_fd` and `follow_symlinks` because `follow_symlinks` (I think) is kinda broken on Windows and I prefer to add