Berker Peksag added the comment:
Thanks for the patch, Anastasia.
--
nosy: +berker.peksag
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
versions: +Python 3.5, Python 3.6 -Python 3.3, Python 3.4
___
Python tracker
Roundup Robot added the comment:
New changeset a912ca4f507b by Berker Peksag in branch '3.5':
Issue #20112: Improve BaseHTTPRequestHandler.error_message_format documentation
https://hg.python.org/cpython/rev/a912ca4f507b
New changeset baed33df1aed by Berker Peksag in branch 'default':
Issue
Changes by Anastasia.Filatova anastasia.n.filat...@gmail.com:
Removed file: http://bugs.python.org/file34467/Issue20112_py27.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20112
___
Changes by Anastasia.Filatova anastasia.n.filat...@gmail.com:
Removed file: http://bugs.python.org/file34469/Issue20112_py34.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20112
___
Changes by Anastasia.Filatova anastasia.n.filat...@gmail.com:
Removed file: http://bugs.python.org/file34468/Issue20112_py33.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20112
___
Changes by Anastasia.Filatova anastasia.n.filat...@gmail.com:
Added file: http://bugs.python.org/file34481/Issue20112_py34.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20112
___
Changes by Anastasia.Filatova anastasia.n.filat...@gmail.com:
Added file: http://bugs.python.org/file34482/Issue20112_py33.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20112
___
Anastasia.Filatova added the comment:
Thank you, Eric for your comments! I see now what doese the 'review' link mean
:) You are right the send_error should be a method not a class variable. I
changed it in a new patch. As regards the responses I prefer don't change it to
a class attribute
Changes by Anastasia.Filatova anastasia.n.filat...@gmail.com:
Added file: http://bugs.python.org/file34483/Issue20112_py27.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20112
___
Anastasia.Filatova added the comment:
Thank you, David, for review! I understood your point of view, an updated patch
will be added soon.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20112
Changes by Anastasia.Filatova anastasia.n.filat...@gmail.com:
Removed file: http://bugs.python.org/file34389/Issue20112_py27.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20112
___
Changes by Anastasia.Filatova anastasia.n.filat...@gmail.com:
Removed file: http://bugs.python.org/file34391/Issue20112_py34.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20112
___
Changes by Anastasia.Filatova anastasia.n.filat...@gmail.com:
Removed file: http://bugs.python.org/file34390/Issue20112_py33.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20112
___
Changes by Anastasia.Filatova anastasia.n.filat...@gmail.com:
Added file: http://bugs.python.org/file34467/Issue20112_py27.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20112
___
Changes by Anastasia.Filatova anastasia.n.filat...@gmail.com:
Added file: http://bugs.python.org/file34468/Issue20112_py33.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20112
___
Changes by Anastasia.Filatova anastasia.n.filat...@gmail.com:
Added file: http://bugs.python.org/file34469/Issue20112_py34.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20112
___
Anastasia.Filatova added the comment:
So new patch is updated. Could someone please give me feedback on it?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20112
___
Éric Araujo added the comment:
Thanks, the doc is much clearer now. Could you also address my comments? (If
you did not get email, the comments can be accessed with the “review” link in
the list of files attached to this report.)
--
nosy: +eric.araujo
R. David Murray added the comment:
My intent here was that the rewrite should specify where the data that gets
placed into the template when it is used comes from. That would be 'responses'
by default, but can be overridden in 'send_error'.
--
___
R. David Murray added the comment:
Hmm. Rereading your patch I see that that is what you are trying to do, but I
find the order of presentation confusing. I would rather see the text focus on
the fact that the string is used by send_error, and that the variables are
filled by default from
Anastasia.Filatova added the comment:
I made a patch on this issue. I added a small example to the description.
Should I provide a more detailed example or that one will be enough? Could
someone please review the patch?
--
keywords: +patch
nosy: +Anastasia.Filatova
Added file:
Changes by Anastasia.Filatova anastasia.n.filat...@gmail.com:
Added file: http://bugs.python.org/file34390/Issue20112_py33.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20112
___
Changes by Anastasia.Filatova anastasia.n.filat...@gmail.com:
Added file: http://bugs.python.org/file34391/Issue20112_py34.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20112
___
New submission from R. David Murray:
The description of error_message_format does not give enough information to use
it. The description should talk about how it is used (ie: using % formatting)
and the fact that when filled in it should form a complete html document
because it will be sent
24 matches
Mail list logo
