[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Changes by Serhiy Storchaka : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Larry Hastings added the comment: Steve, please close this issue when you've confirmed it's now building correctly on Windows. -- ___ Python tracker ___

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Roundup Robot added the comment: New changeset 7a76c462c7f6 by Larry Hastings in branch 'default': Fix Windows build breakage from checkins on Issues #20148 and #20168. https://hg.python.org/cpython/rev/7a76c462c7f6 -- ___ Python tracker

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Steve Dower added the comment: LGTM -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Larry Hastings added the comment: As mentioned on #20148, removing the "static" from the forward declarations breaks it on GCC. (And, of the two, I think GCC is the one being reasonable here.) Attached is a patch that should fix the build for tkinter. -- Added file: http://bugs.pyth

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Steve Dower added the comment: This broke Windows builds because of unnecessary "static" qualifiers on the forward declarations at lines 2685 and 3006 (as discussed on #20323). Removing "static" from these lines fixes the build. -- nosy: +steve.dower resolution: fixed -> status: close

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Serhiy Storchaka added the comment: wantobjects() was not converted due to a bug in Argument Clinic (issue24051). -- dependencies: -Argument Clinic no longer works with single optional argument resolution: -> fixed stage: patch review -> resolved status: open -> closed ___

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Roundup Robot added the comment: New changeset b22ced894d51 by Serhiy Storchaka in branch 'default': Issue #20168: Converted the _tkinter module to Argument Clinic. https://hg.python.org/cpython/rev/b22ced894d51 -- nosy: +python-dev ___ Python tracker

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Changes by Serhiy Storchaka : -- dependencies: +Argument Clinic no longer works with single optional argument ___ Python tracker ___ _

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file39091/tkinter_4.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file39089/tkinter_4.patch ___ Python tracker ___ ___ Python-bugs-list maili

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Serhiy Storchaka added the comment: Updated to the tip. Converted methods getint, getdouble, getboolean, splitlist, split. -- Added file: http://bugs.python.org/file39089/tkinter_4.patch ___ Python tracker ___

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Changes by Serhiy Storchaka : -- components: +Argument Clinic ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Serhiy Storchaka added the comment: Synchronized with tip. -- Added file: http://bugs.python.org/file35437/tkinter_clinic_3.patch ___ Python tracker ___ _

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Serhiy Storchaka added the comment: Here is updated patch. -- versions: +Python 3.5 -Python 3.4 Added file: http://bugs.python.org/file34533/tkinter_clinic_2.patch ___ Python tracker ___

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Serhiy Storchaka added the comment: Here is a patch. -- keywords: +patch nosy: +gpolo stage: -> patch review Added file: http://bugs.python.org/file33528/tkinter_clinic.patch ___ Python tracker ___

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Changes by Serhiy Storchaka : -- dependencies: +Argument Clinic generates invalid code for optional parameter ___ Python tracker ___ _

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Larry Hastings added the comment: Oh, okay. That sounds fine, and I'm not in a hurry. Please post the patch whenever you're ready, thanks! -- ___ Python tracker ___ __

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Serhiy Storchaka added the comment: You misunderstood me. I already have 1018-lines patch which converts about 24 functions and methods to Argument Clinic church. And I'm working on left functions. Do you want to get unfinished patch? -- ___ Python

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Larry Hastings added the comment: So do you think there are any entry points worth converting in _tkinter, or should we close this issue? -- ___ Python tracker ___ _

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Larry Hastings added the comment: (It would have made it easier on me if you'd used the C function names, instead of the names in the module.) I agree. In retrospect, it's not surprising that things in _tkinter aren't suitable, as it appears to be a shunt for calling things in Tcl. For what

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Serhiy Storchaka added the comment: call() just converts all args to Tcl list. Is Argument Clinic supports *args and **kwargs? I'm not sure there is a benefit with using Argument Clinic here. splitlist() and split() first call PyArg_ParseTuple with one argument, check the input, and then may c

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Larry Hastings added the comment: What functions, and what makes them unsuitable? -- ___ Python tracker ___ ___ Python-bugs-list maili

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Changes by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka nosy: +larry ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

New submission from Serhiy Storchaka: In progress. Actually many functions are not very suitable for Argument Clinic. -- components: Extension Modules, Tkinter messages: 207600 nosy: serhiy.storchaka priority: normal severity: normal status: open title: Derby: Convert the _tkinter module