[issue20178] Derby #9: Convert 52 sites to Argument Clinic across 11 files

Erlend E. Aasland added the comment: FYI, sqlite3 was converted to Argument Clinic in bpo-40956. -- ___ Python tracker ___ ___

[issue20178] Derby #9: Convert 52 sites to Argument Clinic across 11 files

Change by Erlend Egeberg Aasland : -- nosy: +erlendaasland ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20178] Derby #9: Convert 52 sites to Argument Clinic across 11 files

Berker Peksag added the comment: I'm working on converting Modules/_sqlite/* to Argument Clinic. -- nosy: +berker.peksag versions: +Python 3.8 -Python 3.5 ___ Python tracker

[issue20178] Derby #9: Convert 52 sites to Argument Clinic across 11 files

Serhiy Storchaka added the comment: For Modules/_curses_panel.c there is special issue, #20171, with the patch. issue20178-sqlite-01.patch is applied almost clearly, but due to changes to Argument Clinic it should be updated. Perhaps more functions can be converted (functions that don't use

[issue20178] Derby #9: Convert 52 sites to Argument Clinic across 11 files

Serhiy Storchaka added the comment: issue20178-cyptes-01.patch is outdated due to changes in Argument Clinic and ctypes. Here is updated and extended patch. -- nosy: +serhiy.storchaka stage: needs patch - patch review Added file:

[issue20178] Derby #9: Convert 52 sites to Argument Clinic across 11 files

Changes by Serhiy Storchaka storch...@gmail.com: -- components: +Argument Clinic ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20178 ___ ___

[issue20178] Derby #9: Convert 52 sites to Argument Clinic across 11 files

Larry Hastings added the comment: All the Derby patches should only go into trunk at this point. -- versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20178 ___

[issue20178] Derby #9: Convert 52 sites to Argument Clinic across 11 files

Larry Hastings added the comment: Larry Hastings added the comment: * As is probably expected, __init__ and __call__ procs can't be converted. I should have a fix in for __init__ and __call__ later today. (Issue #20294.) For the record, you could convert them, you just had to wrap the

[issue20178] Derby #9: Convert 52 sites to Argument Clinic across 11 files

Larry Hastings added the comment: Meador: I'm going to change Argument Clinic so you can get the args and kwargs values passed in to the impl. That's issue #20291; I already added you to it nosy list. With that change in you'll be able to convert sqlite3.connect. --

[issue20178] Derby #9: Convert 52 sites to Argument Clinic across 11 files

Larry Hastings added the comment: In the past few days I added cloning functions, which lets you reuse the parameters and return converter from an existing function. That might help with Modules/_ctypes/_ctypes. -- ___ Python tracker

[issue20178] Derby #9: Convert 52 sites to Argument Clinic across 11 files

Larry Hastings added the comment: All the functions in curses_panel are convertable. The threeMETH_NOARGS functions simply get no arguments. And here's new_panel: new_panel window: object(subclass_of='PyCursesWindow_Type') / -- ___ Python

[issue20178] Derby #9: Convert 52 sites to Argument Clinic across 11 files

Meador Inge added the comment: Attached is a first cut for sqlite3. It is generally OK, but I have the following nits: * As is probably expected, __init__ and __call__ procs can't be converted. * sqlite3.Connection.{execute, executemany, executescript} don't use PyArg_Parse*.

[issue20178] Derby #9: Convert 52 sites to Argument Clinic across 11 files

Meador Inge added the comment: Larry, the attached patch converts what is convertible of Modules/_ctypes/_ctypes. Although, I ran into an odd case with this conversion: the converted functions are each used in *multiple* PyMethodDef tables. So while clinic can generate equivalent code, the

[issue20178] Derby #9: Convert 52 sites to Argument Clinic across 11 files

Meador Inge added the comment: None of the sites in Modules/_curses_panel.c look convertible. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20178 ___

[issue20178] Derby #9: Convert 52 sites to Argument Clinic across 11 files

Meador Inge added the comment: I will pick this one up. -- assignee: - meador.inge nosy: +meador.inge ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20178 ___

[issue20178] Derby #9: Convert 52 sites to Argument Clinic across 11 files

New submission from Larry Hastings: This issue is part of the Great Argument Clinic Conversion Derby, where we're trying to convert as much of Python 3.4 to use Argument Clinic as we can before Release Candidate 1 on January 19. This issue asks you to change the following bundle of files: