[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

Serhiy Storchaka added the comment: New changeset b7047e59a40649d81061acf0044e74cfd426f064 by Zackery Spytz in branch 'master': bpo-20181: Convert the readline module to the Argument Clinic (#14326) https://github.com/python/cpython/commit/b7047e59a40649d81061acf0044e74cfd426f064

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

Zackery Spytz added the comment: PR 14326 converts Modules/readline.c. As the parser module is slated for removal in 3.9 (according to PEP 594), Modules/parsermodule.c should not be converted. -- nosy: +ZackerySpytz ___ Python tracker

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

Change by Zackery Spytz : -- pull_requests: +14146 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/14326 ___ Python tracker ___

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

Change by Tal Einat : -- nosy: -taleinat ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

Roundup Robot added the comment: New changeset c6d468e0ecc6 by Serhiy Storchaka in branch 'default': Issue #20181: Converted the unicodedata module to Argument Clinic. https://hg.python.org/cpython/rev/c6d468e0ecc6 -- nosy: +python-dev ___ Python

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

Larry Hastings added the comment: I finally talked to someone (Thomas Wouters) about this. For something going into trunk that will be part of 3.5, this is fine. Please include a mention that the exception's text messages changed in Misc/NEWS. I can help you write this if you want. I'll

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

Serhiy Storchaka added the comment: The only difference is in error message. For now: unicodedata.name(123) Traceback (most recent call last): File stdin, line 1, in module TypeError: must be str, not int unicodedata.name('123') Traceback (most recent call last): File stdin, line 1, in

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

Larry Hastings added the comment: I read it quickly. It looks basically okay, but I have one issue to discuss right now. Changing from the format unit 'O!' and calling getuchar to the format unit 'C' means a change in semantics. The text in the exception will change. Unfortunately, people

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

Serhiy Storchaka added the comment: Here is a patch for unicodedata. -- keywords: +patch nosy: +serhiy.storchaka Added file: http://bugs.python.org/file38630/unicodedata_clinic.patch ___ Python tracker rep...@bugs.python.org

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

Changes by Serhiy Storchaka storch...@gmail.com: -- components: +Argument Clinic ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20181 ___ ___

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

Larry Hastings added the comment: All the Derby patches should only go into trunk at this point. -- versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20181 ___

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

Tal Einat added the comment: While converting Objects/stringlib/transmogrify.h as part of issue20180 (Derby #11), some changes to Objects/bytesobject.c and Objects/bytearrayobject.c were required. Those changes are included in the relevant patch attached to that issue. -- nosy:

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

Tal Einat added the comment: See nearly complete conversion of Objects/bytearrayobject.c in patch attached to issue20179. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20181 ___

[issue20181] Derby #12: Convert 50 sites to Argument Clinic across 4 files

New submission from Larry Hastings: This issue is part of the Great Argument Clinic Conversion Derby, where we're trying to convert as much of Python 3.4 to use Argument Clinic as we can before Release Candidate 1 on January 19. This issue asks you to change the following bundle of files: