[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Serhiy Storchaka added the comment: New changeset 1bcaa81e520e30f920bd69e46fbf1d67a9107ce1 by Serhiy Storchaka in branch 'master': bpo-20184: Convert termios to Argument Clinic. (GH-22693) https://github.com/python/cpython/commit/1bcaa81e520e30f920bd69e46fbf1d67a9107ce1 --

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Change by Serhiy Storchaka : -- pull_requests: +21664 pull_request: https://github.com/python/cpython/pull/22693 ___ Python tracker ___

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

hai shi added the comment: Looks like `builtins.vars` and `builtins.dir` should be migrated to AC too, so I create PR18512. -- nosy: +shihai1991 ___ Python tracker ___

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Change by hai shi : -- pull_requests: +17889 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/18512 ___ Python tracker ___

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Serhiy Storchaka added the comment: Here is a patch that converts 3 functions in the _json module to Argument Clinic. All other functions doesn't fit with Argument Clinic. -- Added file: http://bugs.python.org/file39292/json_clinic.patch ___ Python

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Roundup Robot added the comment: New changeset 49910ff21ba5 by Serhiy Storchaka in branch 'default': Issue #20184: Converted _dbm and _gdbm modules to Argument Clinic. https://hg.python.org/cpython/rev/49910ff21ba5 -- ___ Python tracker

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Serhiy Storchaka added the comment: The patch updated to the tip. -- Added file: http://bugs.python.org/file39070/dbm_clinic_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20184 ___

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Serhiy Storchaka added the comment: Proposed patch converts _dbm and _gdbm modules to Argument Clinic. -- nosy: +serhiy.storchaka Added file: http://bugs.python.org/file39032/dbm_clinic.patch ___ Python tracker rep...@bugs.python.org

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Changes by Serhiy Storchaka storch...@gmail.com: -- components: +Argument Clinic ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20184 ___ ___

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Nick Coghlan added the comment: Tweaked patch to apply cleanly to trunk, but realised it has been a while since I looked at the current state of argument clinic: * I'm not sure if varargs support has been added yet. If it has, min, max, print, __build_class__ can be converted. If it hasn't,

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Roundup Robot added the comment: New changeset 6219aa966a5f by Nick Coghlan in branch 'default': Issue #20184: Add signature introspection for 30 of the builtins http://hg.python.org/cpython/rev/6219aa966a5f -- nosy: +python-dev ___ Python tracker

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Nick Coghlan added the comment: 30 of the builtin functions now support signature introspection thanks to Argument Clinic :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20184 ___

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Nick Coghlan added the comment: (Well, they'll support it in 3.5...) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20184 ___ ___

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Larry Hastings added the comment: All the Derby patches should only go into trunk at this point. -- versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20184 ___

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Nick Coghlan added the comment: Updated the builtins patch for the 3.4.0 Argument Clinic changes. Also moved the issue back to 3.4, since Larry has indicated that AC conversions are in scope for 3.4.x maintenance releases, so long as no public API behaviour changes. -- nosy:

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Nick Coghlan added the comment: Interpreting the lack of response as this can wait until 3.5. -- assignee: larry - priority: release blocker - normal versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Nick Coghlan added the comment: Larry, if this version looks good to you, I'd like to commit it. - id() is now back to being a properly generated AC function (since AC can now preserve the old C level signature) - sorted() is partially converted and has a __text_signature__ compatible

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Changes by Nick Coghlan ncogh...@gmail.com: Added file: http://bugs.python.org/file33861/issue20184_builtin_conversion_v5.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20184 ___

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Nick Coghlan added the comment: Assigning to myself to make it clear that bltinmodule is the only part of this still under consideration for 3.4. The test_pydoc and test_gdb failures pointed to real issues with the previous patch: - the pydoc errors themselves were incidental, indicating

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Nick Coghlan added the comment: Attached patch shows the new test case I'm using to ensure that all callable builtins have signatures, and once we get it that way, it stays that way. Preliminary goal is signatures for all the non-type objects, and once I get to that point, I'll propose it for

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Nick Coghlan added the comment: More comprehensive patch uploaded - all the non-type callables implemented in bltinmodule.c have been converted or classified with a reason for not being converted yet (see the new test in test_inspect.py for details, as well as the AC 3.4 and AC 3.5 comments

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Nick Coghlan added the comment: I'm going to specifically tackle the bltinmodule side of things using a test driven approach: adding a new test to test_inspect that checks all the builtin names have signatures (I'll explicitly exclude ones that are known not to be handled, like range and

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

Changes by Nadeem Vawda nadeem.va...@gmail.com: -- nosy: +nadeem.vawda ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20184 ___ ___

[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

New submission from Larry Hastings: This issue is part of the Great Argument Clinic Conversion Derby, where we're trying to convert as much of Python 3.4 to use Argument Clinic as we can before Release Candidate 1 on January 19. This issue asks you to change the following bundle of files: