[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Roundup Robot added the comment: New changeset c2e425a05d35 by Christian Heimes in branch 'default': Issue #20193: Fix commit r6f217456b9ba by including clinic/zlibmodule.c.h instead http://hg.python.org/cpython/rev/c2e425a05d35 -- ___ Python tracker

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Serhiy Storchaka added the comment: Thank you for reviews, Nadeem, Larry. -- dependencies: -pydoc fails with the "unspecified" default value resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Roundup Robot added the comment: New changeset 6f217456b9ba by Serhiy Storchaka in branch 'default': Issue #20193: The zlib module now uses Argument Clinic. http://hg.python.org/cpython/rev/6f217456b9ba -- ___ Python tracker

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Nadeem Vawda added the comment: The patch for zlib looks good to me. Thanks for working on this, Serhiy. > We're not allowing changes in semantics for Argument Clinic conversion for > 3.4. If it doesn't currently accept None, we can't add it right now, and > we'll have to save it for 3.5. Fa

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file33719/zlib_clinic_3.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Serhiy Storchaka added the comment: Ah, sorry, here is full patch. Generated file is now named Modules/clinic/zlibmodule.c.h. The behavior is preserved. This case is exact analogue of _sha1.sha1(). No one additional function called when the parameter is not specified, but if it is specified a

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Larry Hastings added the comment: We're not allowing changes in semantics for Argument Clinic conversion for 3.4. If it doesn't currently accept None, we can't add it right now, and we'll have to save it for 3.5. -- ___ Python tracker

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Nadeem Vawda added the comment: The latest patch for zlib seems to be missing Modules/zlibmodule.clinic.c > I suppose that zdict=b'' have same effect as not specifying zdict. Am I right? Probably, but to be on the safe side I'd prefer that we preserve the behavior of not calling deflateSetDicti

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Serhiy Storchaka added the comment: Synchronized with recent Argument Clinic changes. -- Added file: http://bugs.python.org/file33719/zlib_clinic_3.patch ___ Python tracker ___ _

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file33709/zlib_clinic_3.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Serhiy Storchaka added the comment: I suppose that zdict=b'' have same effect as not specifying zdict. Am I right? -- ___ Python tracker ___ _

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Serhiy Storchaka added the comment: Updated patch for zlib reverts reverted decompress(), decompressobj() and Decompress.flush(). It get rids from DEF_WBITS and use MAX_WBITS instead, exposes DEF_BUF_SIZE (former DEFAULTALLOC) to Python level. -- Added file: http://bugs.python.org/file

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file33699/zlib_clinic_2.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Serhiy Storchaka added the comment: Sorry, previous patch didn't contain generated file. -- Added file: http://bugs.python.org/file33700/zlib_clinic_2.patch ___ Python tracker __

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Serhiy Storchaka added the comment: Patch for _lzma was applied without converting LZMACompressor.__init__. Here is a patch for zlib, which doesn't use neither optional groups, nor "unspecified" defaults. Three builtins, decompress(), decompressobj() and Decompress.flush() are left not conver

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Roundup Robot added the comment: New changeset 7ba9642fc800 by Serhiy Storchaka in branch 'default': Issue #20193: The _lzma module now uses Argument Clinic. http://hg.python.org/cpython/rev/7ba9642fc800 -- ___ Python tracker

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Serhiy Storchaka added the comment: Thank you Nadeem. In committed patch fixed the docstring for BZ2Compressor.__init__, and renamed module name "bz2" in clinic declaration is renamed to "_bz2". Here is updated patch for the _lzma module which addresses Nadeem's comment and renames the "lzma"

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Roundup Robot added the comment: New changeset 0a3e02251bd6 by Serhiy Storchaka in branch 'default': Issue #20193: The _bz2 module now uses Argument Clinic. http://hg.python.org/cpython/rev/0a3e02251bd6 -- nosy: +python-dev ___ Python tracker

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Nadeem Vawda added the comment: The bz2 patch looks good to me, aside from a nit with the docstring for BZ2Compressor.__init__. The lzma patch produces a bunch of test failures for me. It looks like the __init__ methods for LZMACompressor and LZMADecompressor aren't accepting keyword args:

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Nadeem Vawda added the comment: The patches for bz2 and lzma look good to me, aside from one nit for lzma. -- ___ Python tracker ___ _

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file33369/lzma_clinic.patch ___ Python tracker ___ ___ Python-bugs-list mai

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file33368/bz2_clinic.patch ___ Python tracker ___ ___ Python-bugs-list mail

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file33370/zlib_clinic.patch ___ Python tracker ___ ___ Python-bugs-list mai

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Changes by Serhiy Storchaka : -- dependencies: +Argument Clinic: add support for __init__, pydoc fails with the "unspecified" default value ___ Python tracker ___ __

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Changes by Serhiy Storchaka : -- dependencies: +Argument Clinic: support for simple expressions? ___ Python tracker ___ ___ Python-bug

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Larry Hastings added the comment: I just realized, you're misunderstanding what the first line of the docstring is. When you run help(function_written_in_Python), the first line of the help is the function's signature rendered in text. That's generated by "pydoc", which gets signature inform

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Larry Hastings added the comment: > Previous approach is not applicable to compressobj because > Py_buffer can't have default value. Seems as compressobj is > not compatible with Argument Clinic. Then perhaps we can fix Argument Clinic to be compatible. Py_buffer doesn't like default values be

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Larry Hastings added the comment: > * I have experimented in zlib_decompressobj, and I got good compact > code, but wrong docstring ("decompressobj(wbits=None, zdict=None)"). > Needed a way to specify optional parameters without default Python > values. Correct signature should be something l

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Larry Hastings added the comment: I did correct that "where is file X" problem; issue #20187 is a meta-issue for the whole Derby, and it has a list of all the issues and what files they map to. I'm sorry that this is not an optimal solution for organization, but it should be workable, and it

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Serhiy Storchaka added the comment: I didn't even know for which of the dozens of random issues Larry randomly assigned these modules. And this organization does not look productive. -- ___ Python tracker

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Meador Inge added the comment: > Larry, I don't want to scatter patches for these related modules and merge > them with patches for totally unrelated modules. And I think it would be > cumbersome to Nadeem Vawda to make reviews in such circumstances. Maybe so, but it will more productive if we

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file33370/zlib_clinic.patch ___ Python tracker ___ ___ Python-bugs-list maili

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Changes by Serhiy Storchaka : -- keywords: +patch Added file: http://bugs.python.org/file33368/bz2_clinic.patch ___ Python tracker ___ ___

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file33369/lzma_clinic.patch ___ Python tracker ___ ___ Python-bugs-list maili

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Serhiy Storchaka added the comment: Here are completed patches for the _bz2 and _lzma modules (only constructors are not converted) and preliminary patch for the zlib module. There are issues in the zlib module: * Argument Clinic generates invalid code for zlib_Decompress_flush (issue20196).

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Larry Hastings added the comment: I'd prefer it if you use the existing Derby issues. It's hard enough for me to keep track of what's going on as it is, and it's unhelpful of you to create a redundant issue. If you'd like some help figuring out how to work with the existing issues please tal

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

Changes by Serhiy Storchaka : -- nosy: +larry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue20193] Derby: Convert the zlib, _bz2 and _lzma modules to use Argument Clinic

New submission from Serhiy Storchaka: In progress. These modules have similar interfaces and common maintainer. -- assignee: serhiy.storchaka components: Extension Modules messages: 207696 nosy: nadeem.vawda, serhiy.storchaka priority: normal severity: normal status: open title: Derby: C