[issue20264] Update patchcheck to looks for files with clinic comments

Changes by Serhiy Storchaka : -- components: +Argument Clinic ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue20264] Update patchcheck to looks for files with clinic comments

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue20264] Update patchcheck to looks for files with clinic comments

Larry Hastings added the comment: I've attached a script here that uses the new tweaked format of Clinic blocks. The new tweaked format isn't checked in yet--that change is being tracked with #20326. Once that's checked in, though, the attached script will check that both the input and output

[issue20264] Update patchcheck to looks for files with clinic comments

Nick Coghlan added the comment: Having clinic work like reindent on "make patchcheck" would be very nice. As a second line of defence, we should also have a server side equivalent of the whitespace check as a repo hook in Mercurial (i.e. don't allow a push when clinic output is out of date).

[issue20264] Update patchcheck to looks for files with clinic comments

Larry Hastings added the comment: Maybe I'm not reading this correctly. It looks like the function returns True if it finds any .c or .h file that contains the string '[clinic input]'. It doesn't seem to only check files that have changed. I was considering adding a checkum for the *input* t

[issue20264] Update patchcheck to looks for files with clinic comments

Zachary Ware added the comment: This could be taken a step further, following the lead of the whitespace fixing checks and just run clinic on files that need it. -- nosy: +zach.ware ___ Python tracker

[issue20264] Update patchcheck to looks for files with clinic comments

New submission from Meador Inge: It has been noted a few times that someone might forget to re-run clinic.py after updating the argument clinic comments. The attached patch adds a new check to patchcheck.py to note when files containing argument clinic comments have been changed. You could take