Serhiy Storchaka added the comment:
The readline module no longer compiled in 3.2. May be we should apply these
patches to 3.2.
--
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20374
Ned Deily added the comment:
This isn't a security issue and in general we do not make changes to branches
in security-fix mode to support new releases of external components or
operating system releases. There are plenty of other fixes that should be
ported to 3.2 if we go down that path.
Arfrever Frehtes Taifersar Arahesis added the comment:
+1 for backporting build fixes for major platforms (e.g. fix for this issue).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20374
Georg Brandl added the comment:
I agree with Ned. 3.2 is not maintained anymore, we only provide security fixes.
(Exceptions prove the rule. One exception I committed today was to stop
test_urllibnet from failing, so that I could better see real failures on the
buildbots.)
--
Changes by koobs koobs.free...@gmail.com:
--
nosy: +koobs
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20374
___
___
Python-bugs-list mailing
Roundup Robot added the comment:
New changeset a7e048674fef by Ned Deily in branch '3.3':
Issue #20374: Avoid compiler warnings when compiling readline with libedit.
http://hg.python.org/cpython/rev/a7e048674fef
New changeset de02d414590d by Ned Deily in branch '3.3':
Issue #20374: delete
Ned Deily added the comment:
Using Serhiy's suggestion, here are patches for 2.7/3.3 and default that
condition the hook function signatures. With these patches, all three branches
compile without warnings and pass test_readline using OS X libedit, readline
6.3-rc2, and an older readline.
Changes by Ned Deily n...@acm.org:
Added file: http://bugs.python.org/file33937/issue20374_no_cast_3x.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20374
___
Benjamin Peterson added the comment:
That is sure ugly, but okay. :)
--
assignee: benjamin.peterson - ned.deily
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20374
___
Roundup Robot added the comment:
New changeset 0b5b0bfcc7b1 by Ned Deily in branch '2.7':
Issue #20374: Avoid compiler warnings when compiling readline with libedit.
http://hg.python.org/cpython/rev/0b5b0bfcc7b1
New changeset 9131a9edcac4 by Ned Deily in branch '3.3':
Issue #20374: Avoid
Roundup Robot added the comment:
New changeset 74c7a6fd8b45 by Ned Deily in branch '2.7':
Issue #20374: delete spurious empty line
http://hg.python.org/cpython/rev/74c7a6fd8b45
New changeset 6616c94d6149 by Ned Deily in branch '3.3':
Issue #20374: delete spurious empty line
Changes by Ned Deily n...@acm.org:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20374
___
Ned Deily added the comment:
FYI, removing the cast causes the following new warnings when compiling 3.3
with gcc-4.2 on OS X 10.5 and 10.6 (haven't checked elsewhere):
Modules/readline.c: In function 'setup_readline':
Modules/readline.c:939: warning: assignment from incompatible pointer type
Benjamin Peterson added the comment:
It doesn't complain on Linux. I suppose if we don't want any warnings, we'd
have to do something like the originally proposed patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20374
Serhiy Storchaka added the comment:
I'm surprised that warnings are emitted at lines 939 and 941, but not 944.
I think that instead type casting, the more robust way is to change hook
functions signatures for on_startup_hook and on_pre_input_hook.
static int
#ifdef _RL_FUNCTION_TYPEDEF /* or
Ned Deily added the comment:
The checked-in fixes break builds on OS X that use the Apple-supplied libedit
readline compatibility layer. See, for example:
http://buildbot.python.org/all/builders/AMD64%20Snow%20Leop%203.x/builds/1077/steps/compile/logs/stdio
gcc -fno-strict-aliasing
Serhiy Storchaka added the comment:
What if remove casts at all? Ned, is it compiled with libedit?
--
keywords: +patch
nosy: +serhiy.storchaka
Added file: http://bugs.python.org/file33682/readline_func_cast.patch
___
Python tracker
Ned Deily added the comment:
Serhiy, I'm not sure I understand your question. libedit includes a GNU
readline compatibility layer and that is what _readline.so builds and links
with on OS X systems (with an ABI of 10.5 and later) since OS X does not ship
with GNU readline. This is also the
Serhiy Storchaka added the comment:
With your patch, _readline.so again builds correctly.
Yes, this is what I wanted to know. Sorry for the awkward formulation.
Type casting is dangerous because it may hide the signature mismatch, which
can cause problems later in run time. It is better to
Benjamin Peterson added the comment:
Okay then. Off we go.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20374
___
___
Python-bugs-list mailing
Roundup Robot added the comment:
New changeset 5e42e5764ac6 by Benjamin Peterson in branch '2.7':
new plan: just remove typecasts (closes #20374)
http://hg.python.org/cpython/rev/5e42e5764ac6
New changeset fc62fcd8e990 by Benjamin Peterson in branch '3.3':
new plan: just remove typecasts
Changes by jhl j...@mafipulation.org:
--
type: - compile error
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20374
___
___
Python-bugs-list
New submission from jhl:
Python 2.7.6 does not compile with readline 6.3 (rc1).
It looks like the RL_FUNCTION_TYPEDEF support in Modules/readline.c is not
quite complete.
The following patch works for me, both for 2.7.6 and 3.3.3.
--- a/Modules/readline.c2013-11-10 18:36:41.0
Changes by jhl j...@mafipulation.org:
--
versions: +Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20374
___
___
Python-bugs-list
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever, benjamin.peterson, georg.brandl, larry
priority: normal - release blocker
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 79b82ebc4fd1 by Benjamin Peterson in branch '2.7':
use new readline function types (closes #20374)
http://hg.python.org/cpython/rev/79b82ebc4fd1
New changeset fb2259d9f6b4 by Benjamin Peterson in branch '3.3':
use new readline function types
26 matches
Mail list logo
