[issue20508] IndexError from ipaddress._BaseNetwork.__getitem__ has no message

2016-06-11 Thread Gareth Rees
Gareth Rees added the comment: Thank you for applying this patch. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue20508] IndexError from ipaddress._BaseNetwork.__getitem__ has no message

2016-06-11 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.5 ___ Python tracker ___ _

[issue20508] IndexError from ipaddress._BaseNetwork.__getitem__ has no message

2016-06-11 Thread Roundup Robot
Roundup Robot added the comment: New changeset bc758c62bc4f by Berker Peksag in branch 'default': Issue #20508: Improve exception message of IPv{4,6}Network.__getitem__ https://hg.python.org/cpython/rev/bc758c62bc4f -- nosy: +python-dev ___ Python tra

[issue20508] IndexError from ipaddress._BaseNetwork.__getitem__ has no message

2016-06-11 Thread Berker Peksag
Berker Peksag added the comment: Thank you Gareth. I will commit ipaddress.patch this weekend. -- ___ Python tracker ___ ___ Python-bu

[issue20508] IndexError from ipaddress._BaseNetwork.__getitem__ has no message

2016-06-11 Thread Gareth Rees
Gareth Rees added the comment: I've attached a revised patch that addresses Berker Peksag's concerns: 1. The message associated with the IndexError is now "address out of range" with no information about which address failed or why. 2. There's a new test case for an IndexError from an IPv6 add

[issue20508] IndexError from ipaddress._BaseNetwork.__getitem__ has no message

2016-06-09 Thread Mark Lawrence
Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue20508] IndexError from ipaddress._BaseNetwork.__getitem__ has no message

2016-06-09 Thread Berker Peksag
Berker Peksag added the comment: +1 for "address index out of range". The current test only covers the first IndexError. We also need to add another one for the else branch. -- nosy: +berker.peksag versions: +Python 3.6 ___ Python tracker

[issue20508] IndexError from ipaddress._BaseNetwork.__getitem__ has no message

2015-02-14 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- keywords: +easy, needs review stage: -> patch review versions: +Python 3.5 -Python 3.4 ___ Python tracker ___ __

[issue20508] IndexError from ipaddress._BaseNetwork.__getitem__ has no message

2015-02-14 Thread Mark Lawrence
Mark Lawrence added the comment: Could someone review the attached patch please. I've looked at the test code and there is one assertRaises for IndexError which I'm assuming covers this case. -- nosy: +BreamoreBoy ___ Python tracker

[issue20508] IndexError from ipaddress._BaseNetwork.__getitem__ has no message

2014-02-04 Thread Ned Deily
Changes by Ned Deily : -- nosy: +ncoghlan, pmoody ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue20508] IndexError from ipaddress._BaseNetwork.__getitem__ has no message

2014-02-04 Thread Gareth Rees
Changes by Gareth Rees : -- type: behavior -> enhancement ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue20508] IndexError from ipaddress._BaseNetwork.__getitem__ has no message

2014-02-04 Thread Gareth Rees
New submission from Gareth Rees: If you try to look up an out-of-range address from an object returned by ipaddress.ip_network, then ipaddress._BaseNetwork.__getitem__ raises an IndexError with no message: Python 3.4.0b3 (default, Jan 27 2014, 02:26:41) [GCC 4.2.1 Compatible Apple LLVM