[issue20519] Replace uuid ctypes usage with an extension module.

Antoine Pitrou added the comment: New changeset a106aec2ed6ba171838ca7e6ba43c4e722bbecd1 by Antoine Pitrou in branch 'master': bpo-11063, bpo-20519: avoid ctypes and improve import time for uuid (#3796)

[issue20519] Replace uuid ctypes usage with an extension module.

STINNER Victor added the comment: There are too many uuid open issues proposing similar changes. I mark this issue as a duplicate of bpo-11063 to avoid splitted discussions. Please continue the discussion there! -- resolution: -> duplicate stage: patch

[issue20519] Replace uuid ctypes usage with an extension module.

Antoine Pitrou added the comment: https://github.com/python/cpython/pull/3796 updates the patch for 3.7 and improves on it a bit by making initialization lazy. -- nosy: +pitrou ___ Python tracker

[issue20519] Replace uuid ctypes usage with an extension module.

Change by Antoine Pitrou : -- versions: +Python 3.7 -Python 3.5 ___ Python tracker ___ ___

[issue20519] Replace uuid ctypes usage with an extension module.

Change by Antoine Pitrou : -- pull_requests: +3781 ___ Python tracker ___ ___

[issue20519] Replace uuid ctypes usage with an extension module.

Gustavo J. A. M. Carneiro added the comment: New patch that: 1. adds assert(sizeof(uuid_t) == 16); to the extension module; 2. fixes the code path when ctypes has to be used instead of the extension module (needed a bit more refactoring, apologies if it makes the diff harder to read); 3.

[issue20519] Replace uuid ctypes usage with an extension module.

Gustavo J. A. M. Carneiro added the comment: One issue of note is regarding generate_time(). Originally I found ctypes bindings for this function, so I wrapped it as well in the extension module. However, it doesn't appear to be used... -- ___

[issue20519] Replace uuid ctypes usage with an extension module.

Gustavo J. A. M. Carneiro added the comment: This patch fixes the Mac OS X issue @haypo pointed out. -- Added file: http://bugs.python.org/file40865/issue20519_10941v2.diff ___ Python tracker

[issue20519] Replace uuid ctypes usage with an extension module.

STINNER Victor added the comment: New review (question for Windows). -- ___ Python tracker ___ ___

[issue20519] Replace uuid ctypes usage with an extension module.

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue20519] Replace uuid ctypes usage with an extension module.

R. David Murray added the comment: Thanks. This looks like a good idea, but I'll leave it to someone with more experience with this module to review it. Let's change this issue to an enhancement request for uuid instead. If someone wants to work on the cycle-in-ctypes problem they can open

[issue20519] Replace uuid ctypes usage with an extension module.

Serhiy Storchaka added the comment: See also issue5885. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20519 ___ ___ Python-bugs-list mailing