[issue2052] Allow changing difflib._file_template character encoding.

Berker Peksag added the comment: Thanks Serhiy. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue2052] Allow changing difflib._file_template character encoding.

Roundup Robot added the comment: New changeset e058423d3ca4 by Berker Peksag in branch 'default': Issue #2052: Add charset parameter to HtmlDiff.make_file(). https://hg.python.org/cpython/rev/e058423d3ca4 -- nosy: +python-dev ___ Python tracker

[issue2052] Allow changing difflib._file_template character encoding.

Serhiy Storchaka added the comment: LGTM -- assignee: -> berker.peksag stage: patch review -> commit review ___ Python tracker ___ ___

[issue2052] Allow changing difflib._file_template character encoding.

Changes by Berker Peksag : Added file: http://bugs.python.org/file38484/issue2052_v4.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue2052] Allow changing difflib._file_template character encoding.

Changes by Berker Peksag : Added file: http://bugs.python.org/file38483/issue2052_v3.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue2052] Allow changing difflib._file_template character encoding.

Berker Peksag added the comment: Here is an updated patch. Thanks for the review, Serhiy. I will open a new issue for the HTML 5 part of the patch. -- Added file: http://bugs.python.org/file38474/issue2052_v2.diff ___ Python tracker

[issue2052] Allow changing difflib._file_template character encoding.

Serhiy Storchaka added the comment: May be updating the markup to HTML5 should be different issue. issue2052_html5_v2.diff not only adds charset in HTML5 format, it totally changes the template. This definitely a separate issue. -- nosy: +serhiy.storchaka _

[issue2052] Allow changing difflib._file_template character encoding.

Changes by Masato HASHIMOTO : -- nosy: +hashimo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue2052] Allow changing difflib._file_template character encoding.

Berker Peksag added the comment: Attaching a new version of issue2052_html5.diff. Changes: - Switch from px to em in CSS - Cleanup markup a bit (e.g. delete redundant colgroup tags) -- Added file: http://bugs.python.org/file35273/issue2052_html5_v2.diff _

[issue2052] Allow changing difflib._file_template character encoding.

Changes by Berker Peksag : Added file: http://bugs.python.org/file35245/issue2052_html5.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue2052] Allow changing difflib._file_template character encoding.

Berker Peksag added the comment: Attaching two patches: issue2052.diff adds a "charset" keyword argument to HtmlDiff.make_file(). issue2052_html5.diff also adds a "charset" keyword argument to HtmlDiff.make_file() and updates the markup of HtmlDiff() to HTML5. I tested it with Firefox 29 and

[issue2052] Allow changing difflib._file_template character encoding.

Changes by Senthil Kumaran : -- nosy: -orsenthil ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue2052] Allow changing difflib._file_template character encoding.

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue2052] Allow changing difflib._file_template character encoding.

Ezio Melotti added the comment: I haven't looked at the code, but if an HTML page is generated it should probably be updated to use HTML5 and . -- ___ Python tracker ___

[issue2052] Allow changing difflib._file_template character encoding.

Terry J. Reedy added the comment: After thinking about it more, the real problem is that the charset setting must match the chars used and how they re encoded, so no one setting is right for all uses. An alternative to changing the default in existing versions is to at least document what it i

[issue2052] Allow changing difflib._file_template character encoding.

Terry J. Reedy added the comment: In 3.2, it is line 1629: content="text/html; charset=ISO-8859-1" /> That charset was only standard for Western European documents limited to that charset. Now, even such limited-char docs often use 'utf-8' (python.org does). The result of putting an

[issue2052] Allow changing difflib._file_template character encoding.

R. David Murray added the comment: I believe that charset is the standard default for html, which would make this a feature request. -- assignee: tim_one -> nosy: +r.david.murray stage: unit test needed -> needs patch type: behavior -> feature request versions: +Python 3.2 -Python 2.6

[issue2052] Allow changing difflib._file_template character encoding.

Mark Lawrence added the comment: difflib._file_template is still hard-coded in py3k SVN. I'm unsure as to whether this is a feature request, a behaviour issue or not an issue at all, can someone please advise, thanks. -- nosy: +BreamoreBoy ___ Pyt

[issue2052] Allow changing difflib._file_template character encoding.

Changes by Brian Curtin : -- stage: -> test needed versions: +Python 2.6 -Python 2.5 ___ Python tracker ___ ___ Python-bugs-list maili

[issue2052] Allow changing difflib._file_template character encoding.

Changes by Sean Reifschneider <[EMAIL PROTECTED]>: -- assignee: -> tim_one nosy: +tim_one priority: -> normal title: Lack of difflib.HtmlDiff unicode support -> Allow changing difflib._file_template character encoding. __ Tracker <[EMAIL PROTECTED]>