[issue20547] Use specific asserts in bigmem tests

Changes by Serhiy Storchaka : -- resolution: -> rejected stage: patch review -> resolved status: open -> closed Added file: http://bugs.python.org/file46778/test_bigmem_asserts_3.patch ___ Python tracker

[issue20547] Use specific asserts in bigmem tests

Changes by Serhiy Storchaka : -- pull_requests: +696 ___ Python tracker ___ ___

[issue20547] Use specific asserts in bigmem tests

Serhiy Storchaka added the comment: Additionally, the more specific tests introduce some additional opacity that is harmful for knowing what methods and operators are specifically used internally in test method. For end users of Python, they don't have to worry much about this, but we as

[issue20547] Use specific asserts in bigmem tests

Raymond Hettinger added the comment: I try to be very careful. It's great to be careful, but it is a smarter move to not change the test suite at all (except in cases where there is a known problem). There is almost zero benefit to the patch (i.e. the tests are currently not failing and

[issue20547] Use specific asserts in bigmem tests

Terry J. Reedy added the comment: Patch2 looks correct, given that the replacement is the right thing to do. The assertTrue error message 'False is not true' is definitely not helpful. But I see Raymond's point. I think these patches should be discussed on pydev. -- nosy: +terry.reedy

[issue20547] Use specific asserts in bigmem tests

Ezio Melotti added the comment: For end users of Python, they don't have to worry much about this, but we as developers of core types really care whether self.assertLessThan(x, y) really does x y, or x.__lt__(y), or not y = x, etc. FWIW the assert methods should guarantee that the

[issue20547] Use specific asserts in bigmem tests

Raymond Hettinger added the comment: These should be backported. And it probably shouldn't be done at all unless there is an actual failure with an uninformative error message. Otherwise, you're just destabilizing the test suite and creating unnecessary code churn. In the case of the

[issue20547] Use specific asserts in bigmem tests

New submission from Serhiy Storchaka: The proposed patch makes bigmem tests use more specific asserts. This will provide more useful failure report. -- components: Tests files: test_bigmem_asserts.patch keywords: easy, patch messages: 210544 nosy: serhiy.storchaka priority: normal