[issue20556] Use specific asserts in threading tests

2015-03-05 Thread Mark Lawrence
Mark Lawrence added the comment: Cut and paste error? if verbose: @@ -110,17 +110,17 @@ for t in threads: t.join() self.assertTrue(not t.is_alive()) +self.assertFalse(t.is_alive()) -- nosy: +BreamoreBoy ___

[issue20556] Use specific asserts in threading tests

2015-03-06 Thread Demian Brecht
Demian Brecht added the comment: LGTM -- nosy: +demian.brecht stage: patch review -> commit review ___ Python tracker ___ ___ Python-b

[issue20556] Use specific asserts in threading tests

2016-01-18 Thread Berker Peksag
Berker Peksag added the comment: test_threading_asserts_2.patch looks good to me. -- nosy: +berker.peksag stage: patch review -> commit review versions: -Python 3.4 ___ Python tracker _

[issue20556] Use specific asserts in threading tests

2016-03-13 Thread Robert Collins
Robert Collins added the comment: @Serhiy care to commit it? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20556] Use specific asserts in threading tests

2016-03-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 791d7ef006d3 by Serhiy Storchaka in branch '3.5': Issue #20556: Used specific assert methods in threading tests. https://hg.python.org/cpython/rev/791d7ef006d3 New changeset 9f8db4d1e149 by Serhiy Storchaka in branch '2.7': Issue #20556: Used specif

[issue20556] Use specific asserts in threading tests

2016-03-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you all for your reviews. -- assignee: -> serhiy.storchaka resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue20556] Use specific asserts in threading tests

2014-02-07 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: The proposed patch makes the threading module tests use more specific asserts. This will provide more useful failure report. -- components: Tests files: test_threading_asserts.patch keywords: patch messages: 210562 nosy: brett.cannon, pitrou, serhiy

[issue20556] Use specific asserts in threading tests

2015-07-29 Thread Robert Collins
Robert Collins added the comment: ping @serhiy - there's a bug in the patch. Moving back to patch review. -- nosy: +rbcollins stage: commit review -> patch review ___ Python tracker

[issue20556] Use specific asserts in threading tests

2015-08-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Yes, I missed to remove one old assertion. Thanks Mark. -- versions: +Python 3.5, Python 3.6 -Python 3.3 Added file: http://bugs.python.org/file40102/test_threading_asserts_2.patch ___ Python tracker