Roundup Robot added the comment:
New changeset 9c27c9844be2 by Vinay Sajip in branch 'default':
Closes #20558: Improved implementation of error handling.
http://hg.python.org/cpython/rev/9c27c9844be2
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
Roundup Robot added the comment:
New changeset 46fe23e000a1 by Vinay Sajip in branch '3.4':
Issue #20558: Improved implementation of error handling.
http://hg.python.org/cpython/rev/46fe23e000a1
--
___
Python tracker rep...@bugs.python.org
Changes by Vinay Sajip vinay_sa...@yahoo.co.uk:
--
assignee: - vinay.sajip
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20558
___
___
Vinay Sajip added the comment:
3.3, 3.4 and default branches will be updated in due course.
--
versions: -Python 2.7
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20558
___
Roundup Robot added the comment:
New changeset 41e49f1c5bd8 by Vinay Sajip in branch '2.7':
Issue #20558: Improved implementation of error handling.
http://hg.python.org/cpython/rev/41e49f1c5bd8
--
nosy: +python-dev
___
Python tracker
Garrett Cooper added the comment:
Updated patch to incorporate Vinay's comments. Thanks :)!
--
Added file: http://bugs.python.org/file34030/patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20558
Changes by Garrett Cooper yaneg...@gmail.com:
Removed file: http://bugs.python.org/file33986/patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20558
___
Vinay Sajip added the comment:
There's a small possibility that someone could be relying on
logging.config.RESET_ERROR being present, so I think it makes more sense to:
1. Leave RESET_ERROR as a module attribute, but set it unconditionally to
errno.ECONNRESET.
2. Use e.errno rather than
Changes by Garrett Cooper yaneg...@gmail.com:
--
components: +Library (Lib)
type: - behavior
versions: +Python 2.7, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20558
___
New submission from Garrett Cooper:
The logging module checks for ECONNRESET if it's equal to 104. This is valid on
Linux, but not [some] other OSes. On FreeBSD and OpenBSD [*] it's 54, not 104.
The attached patch fixes the logging code to check for errno.ECONNRESET in
!win32 environments.
Changes by Ned Deily n...@acm.org:
--
nosy: +vinay.sajip
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20558
___
___
Python-bugs-list mailing list
R. David Murray added the comment:
On windows, errno.ECONNRESET is set equal to errno.WSAECONNRESET.
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20558
___
Garrett Cooper added the comment:
Good to know!
I updated the patch to remove the errno abstraction, grab the errno attribute
from the OSError, and sort the imports.
--
Added file: http://bugs.python.org/file33986/patch
___
Python tracker
13 matches
Mail list logo