Serhiy Storchaka added the comment:
Thank you for your patch Franck. But it would be more useful to output all mode
argument, not only wrong character. And it should be wrapped in a tuple to
prevent subtle formatting error.
--
nosy: +serhiy.storchaka
versions: +Python 3.5 -Python 3.3
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
type: enhancement - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20604
___
Roundup Robot added the comment:
New changeset 34c7be03259b by Serhiy Storchaka in branch '3.4':
Issue #20604: Added missed invalid mode in error message of socket.makefile().
https://hg.python.org/cpython/rev/34c7be03259b
New changeset d5b36edeecdb by Serhiy Storchaka in branch 'default':
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20604
___
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +pitrou
versions: -Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20604
___
New submission from Franck Michea:
Hi! Noticed that the wrong mode was missing from the error message of
socket.makefile. Nothing important, but this patch fixes the thing anyway, if
you want it.
--
components: Library (Lib)
files: missing_mode_in_error.patch
keywords: patch
messages:
