[issue20744] shutil should not use distutils

Derek Chiang added the comment: Cool, thanks for doing this! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20744] shutil should not use distutils

Changes by A.M. Kuchling : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue20744] shutil should not use distutils

Roundup Robot added the comment: New changeset 681e20f8b717 by Andrew Kuchling in branch 'default': #20744: don't try running an external 'zip' in shutil.make_archive() http://hg.python.org/cpython/rev/681e20f8b717 -- nosy: +python-dev ___ Python trac

[issue20744] shutil should not use distutils

A.M. Kuchling added the comment: Yes, tests are only run after a change is committed and pushed into Mercurial; this is done by BuildBot https://www.python.org/dev/buildbot/ . So it's a good idea to run tests before submitting a patch or committing a change. No matter how trivial a change seem

[issue20744] shutil should not use distutils

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue20744] shutil should not use distutils

Éric Araujo added the comment: Not currently. Tests run automatically after a patch is merged, which is why patch authors should run tests (especially if they’re changing something missing tests, or adding a new feature and tests for it). -- ___ Py

[issue20744] shutil should not use distutils

Derek Chiang added the comment: I didn't because the patch seemed trivial. I'm sure there are automated tests that will be run before the patch gets merged? -- ___ Python tracker _

[issue20744] shutil should not use distutils

A.M. Kuchling added the comment: Derek: thanks for your patch! However, did you run the test suite for the shutil module to verify that your change is correct? (The developer guide discusses running tests at http://docs.python.org/devguide/runtests.html ) -- nosy: +akuchling ___

[issue20744] shutil should not use distutils

Éric Araujo added the comment: Patch looks good to me. -- stage: needs patch -> patch review versions: +Python 3.5 -Python 3.3, Python 3.4 ___ Python tracker ___

[issue20744] shutil should not use distutils

Derek Chiang added the comment: New contributor here. I'm submitting a patch; please let me know if I'm doing something wrong :) -- keywords: +patch nosy: +derekchiang93 Added file: http://bugs.python.org/file34283/patch-20744.diff ___ Python tracke

[issue20744] shutil should not use distutils

Éric Araujo added the comment: Agreed; this looks like a relic. zlib is optional, but zipfile is always in the standard library. -- nosy: +eric.araujo ___ Python tracker ___ __

[issue20744] shutil should not use distutils

Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue20744] shutil should not use distutils

Ronald Oussoren added the comment: Why is _call_external_zip needed at all? The code says it is used when the zipfile module is not available, but that module is part of the stdlib and should always be available. -- nosy: +ronaldoussoren ___ Python

[issue20744] shutil should not use distutils

Antoine Pitrou added the comment: Does it pose an actual problem? -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing

[issue20744] shutil should not use distutils

New submission from Matthias Klose: shutil imports distutils in _call_external_zip just for the calling of an external command. This should be done using subprocess these days. -- components: Library (Lib) messages: 212007 nosy: doko priority: normal severity: normal stage: needs patch