Saimadhav Heblikar added the comment:
test_DirBrowserTreeItem (idlelib.idle_test.test_pathbrowser.PathBrowserTest)
... ok
test_PathBrowserTreeItem (idlelib.idle_test.test_pathbrowser.PathBrowserTest)
... ok
--
Ran 2 tests in
New submission from Saimadhav Heblikar:
This patch does
1.Remove pep8 violations in PathBrowser.py . Replaces file,dir,sorted by
file_,dir_,sorted_ respectively.
2.Extends test coverage for PathBrowser.py in idle_test/test_PathBrowser.py
New modules now under tests include
Steven D'Aprano added the comment:
I think you may have misread PEP 8. It does not recommend a trailing underscore
for names that shadow built-ins (e.g. file_ instead of file), it only
recommends a trailing underscore when you need to use a keyword as a name (e.g.
class_ instead of class).
Terry J. Reedy added the comment:
We do not usually make pure style changes in a file unless the code is being
reviewed and edited. Even then, I focus on changes that make the file easier to
read and understand, as is necessary to write tests. One example is adding
missing spaces after commas
Saimadhav Heblikar added the comment:
Well,thank you for the feedback to both .
I will try to make a new patch , during this weekend,
removing the name changes
to add docstrings
and add a human testable dialog for pathbrowser,as is present in other tests.
--
