SilentGhost added the comment:
Re msg233465: it doesn't seem like a particularly good justification to remove
something that is not hurting anyone. The problem now is that because
http.HTTPStatus is an enumeration, it cannot be extended, therefore when
someone encounters these non-standard
Berker Peksag added the comment:
Committed now, sorry about the delay. Thanks for the patch, Demian.
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
Demian Brecht added the comment:
No worries, thanks for taking care of merging it Berker.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20898
___
Roundup Robot added the comment:
New changeset c8647dab4780 by Berker Peksag in branch 'default':
Issue #20898: Add a HTTP status codes section to avoid duplication in HTTP
docs.
https://hg.python.org/cpython/rev/c8647dab4780
--
nosy: +python-dev
Martin Panter added the comment:
Just noticed the new documentation says “http.HTTPStatus.OK is also available
as . . . http.server.OK”. I think this is wrong; only the client module (and
now the top-level package) have those constants. The enum values are only
available in the server module
Roundup Robot added the comment:
New changeset 3a95a74aca4e by Berker Peksag in branch 'default':
Issue #20898: Enum names are only available in the http.client module as
constants.
https://hg.python.org/cpython/rev/3a95a74aca4e
--
___
Python
Berker Peksag added the comment:
Good catch, thank you Martin.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20898
___
___
Python-bugs-list
Demian Brecht added the comment:
Ping. Would be nice to get this change in before 3.5.0a1.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20898
___
Berker Peksag added the comment:
This is mostly a documentation update. Documentation updates can be committed
anytime. Also, feature freeze for 3.5 will be started by Beta 1, not Alpha 1
(see PEP 478).
I'll commit the patch this weekend. Thanks!
--
Demian Brecht added the comment:
The attached patch is a rework of the http.HTTPStatus docs to include links to
the RFCs. While working through this, I noticed that I may have been a little
overzealous in inclusion of some of the status codes. Some non-standard codes
have been deprecated or
Berker Peksag added the comment:
LGTM. Great patch, thanks!
--
assignee: - berker.peksag
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20898
___
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
assignee: rhettinger -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20898
___
___
Demian Brecht added the comment:
The patch in #21793 has been merged, resolving this issue as well. This should
now be closed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20898
___
Berker Peksag added the comment:
I think the documentation part of the patch is still useful.
--
components: +Documentation -Extension Modules
nosy: +berker.peksag
stage: - commit review
___
Python tracker rep...@bugs.python.org
Demian Brecht added the comment:
@Berker: Good point, although I think that the status code table in
http.client.rst should be merged with the one in http.rst as to avoid
redundancy (newly added status codes should also have links added). The table
in http.client.rst should likely be replaced
Demian Brecht added the comment:
Being this is tagged for 3.5, I've refactored status codes as part of #21793.
Should that be accepted and merged, that will also clear up this issue.
--
___
Python tracker rep...@bugs.python.org
Changes by Florent Xicluna florent.xicl...@gmail.com:
--
nosy: +flox
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20898
___
___
Python-bugs-list
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
assignee: - rhettinger
nosy: +rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20898
___
Demian Brecht added the comment:
I actually made a similar change for issue #15025 earlier today. One of the two
should likely be closed as a dupe.
--
nosy: +dbrecht
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20898
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20898
___
___
Python-bugs-list
R. David Murray added the comment:
Thanks. That patch looks good except that it is missing the corresponding
documentation changes, but...
I just noticed that this table is a partial duplicate of the table in
http.server. I suspect this has historical origins, but I don't see any reason
to
Filip Malczak added the comment:
If we're getting out of original scope, then I wonder... Maybe we should keep
only standard status codes here? If not, which should we support, and which
not? What about custom Spring 420 Method Failure?
One way to clean up mess here is to create some
Changes by Daniel Andrade Groppe x16...@gmail.com:
Removed file: http://bugs.python.org/file34433/issue20898.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20898
___
Daniel Andrade Groppe added the comment:
Here goes the patch once again, this time with the changes to the documentation.
Two files were modified:
1. /Lib/http/client.py
2. /Doc/library/http.client.rst
Hope this helps until a decision is made on how to remove duplicate codes in
http.clinet
Daniel Andrade Groppe added the comment:
Added missing constants and response status codes:
Constants:
ALREADY_REPORTED, PERMANENT_REDIRECT, LOOP_DETECTED
Response status codes:
102, 207, 208, 226, 308, 422, 423, 424, 426, 507, 508
--
components: +Extension Modules -Library (Lib)
Changes by Filip Malczak filip.malc...@gmail.com:
--
title: Missin 507 response description - Missing 507 response description
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20898
___
R. David Murray added the comment:
Looks like that's not the only code that was missed (I see 102 is also not
listed).
What happened was that the responses table was originally part of urllib2, and
was moved into httplib (back when it was httplib). But httplib had more
response codes in it
Changes by Benjamin Peterson bp+pyb...@benjamin-peterson.org:
--
components: +Library (Lib) -IO
keywords: +easy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20898
___
28 matches
Mail list logo
