[issue20900] distutils register command should print text, not bytes repr

Berker Peksag added the comment: Thanks for the patch ingrid! -- assignee: eric.araujo -> resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue20900] distutils register command should print text, not bytes repr

Roundup Robot added the comment: New changeset 02824cee7624 by Berker Peksag in branch '3.5': Issue #20900: distutils register command now decodes HTTP responses correctly https://hg.python.org/cpython/rev/02824cee7624 New changeset b0be24a2f16c by Berker Peksag in branch 'default': Issue

[issue20900] distutils register command should print text, not bytes repr

Berker Peksag added the comment: issue20900.patch looks good to me. We are already testing output of "python -setup.py upload --show-response" in Lib/distutils/tests/test_upload.py so I removed test_show_reponse and tweaked test_upload to test the whole line: -

[issue20900] distutils register command should print text, not bytes repr

ingrid added the comment: I'm not quite clear on what you mean, could you please post an example output? Initially the response was not showing up at all for me because the announce call in register was missing a log level, but when I used log.INFO, the response did print for me, and it did

[issue20900] distutils register command should print text, not bytes repr

Éric Araujo added the comment: Were you able to reproduce the bug before you changed the code? I saw clean text when registering a release with success, and clean text too when trying to register a release for a project I was not owner of. -- ___

[issue20900] distutils register command should print text, not bytes repr

ingrid added the comment: Here is a patch. I made the register show-response format consistent with the upload show-response format and added tests for both. Please let me know if you have any feedback. -- keywords: +patch Added file: http://bugs.python.org/file34436/issue20900.patch

[issue20900] distutils register command should print text, not bytes repr

Éric Araujo added the comment: Thank you, the patch looks excellent. I’ll apply it in a day or two. -- assignee: - eric.araujo stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20900

[issue20900] distutils register command should print text, not bytes repr

New submission from Éric Araujo: “python3 setup.py register --show-response“ will display something like --b'xxx'--. The HTTP response body should be decoded to text for display, instead of the repr of a bytes object. Setting the “easy” keyword: thanks to unittest.mock,

[issue20900] distutils register command should print text, not bytes repr

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20900 ___

[issue20900] distutils register command should print text, not bytes repr

ingrid added the comment: I haven't had to register a python package before. Is there a way to reproduce this without actually creating an entry in PyPI? -- nosy: +ingrid ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20900

[issue20900] distutils register command should print text, not bytes repr

Éric Araujo added the comment: To get a better idea of the problem, you can run the code for real using https://testpypi.python.org/pypi as repository URL. Then, unittest.mock provides a way to write a unit test that reproduces the bug without actually sending an HTTP request to any server.

[issue20900] distutils register command should print text, not bytes repr

ingrid added the comment: Ah, thanks! I'm looking at this now. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20900 ___ ___ Python-bugs-list