[issue20918] Logging of logging exceptions can fail in 3.4 if args are unprintable

2014-03-18 Thread the mulhern
the mulhern added the comment: Thanks for the fix. When you say having repr raise is a pretty unusual occurrence you probably mean having repr raise should be a pretty unusual occurrence. I think its more usual than you realize and the regression in 3.4 will have consequences. --

[issue20918] Logging of logging exceptions can fail in 3.4 if args are unprintable

2014-03-18 Thread R. David Murray
R. David Murray added the comment: Did you reopen the issue accidentally? The bug has been fixed. -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20918 ___

[issue20918] Logging of logging exceptions can fail in 3.4 if args are unprintable

2014-03-14 Thread R. David Murray
R. David Murray added the comment: Yes on 3.3 fixes, but you are right that it doesn't need fixed there. This appears to be a 3.4 regression. I used exactly the test you suggest to reproduce it on 3.4...there there is a chained traceback and Done does not get printed. So, the original

[issue20918] Logging of logging exceptions can fail in 3.4 if args are unprintable

2014-03-14 Thread the mulhern
the mulhern added the comment: Yes, I really misinterpreted what I saw. So glad it's a bug anyway and I'm not just wasting your time ;) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20918

[issue20918] Logging of logging exceptions can fail in 3.4 if args are unprintable

2014-03-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 73c2a70e4b35 by Vinay Sajip in branch 'default': Closes #20918: Added handling for exceptions during fallback output of logging exceptions. http://hg.python.org/cpython/rev/73c2a70e4b35 -- nosy: +python-dev resolution: - fixed stage:

[issue20918] Logging of logging exceptions can fail in 3.4 if args are unprintable

2014-03-14 Thread Vinay Sajip
Vinay Sajip added the comment: This fix doesn't seem to meet the criteria for cherry-picking for 3.4 - Only important interface changes, new features, or bugfixes should be checked in now - so I haven't created a separate cherry-pick issue for it. But I will add larry to nosy in case he

[issue20918] Logging of logging exceptions can fail in 3.4 if args are unprintable

2014-03-14 Thread R. David Murray
R. David Murray added the comment: At this point only things that would make it a brown bag release (broken out of the box) would get cherry picked. I agree that this doesn't qualify...having repr raise is a pretty unusual occurrence. -- ___