Roundup Robot added the comment:
New changeset 5d645f290d6a by R David Murray in branch '3.4':
#20976: remove unneeded quopri import in email.utils.
http://hg.python.org/cpython/rev/5d645f290d6a
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset d308c20bf2f4 by R David Murray in branch 'default':
Merge #20976: remove unneeded quopri import in email.utils.
http://hg.python.org/cpython/rev/d308c20bf2f4
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset f6f691ff27b9 by Victor Stinner in branch '3.4':
Issue #20976: pyflakes: Remove unused imports
http://hg.python.org/cpython/rev/f6f691ff27b9
New changeset 714002a5c1b7 by Victor Stinner in branch 'default':
(Merge 3.4) Issue #20976: pyflakes: Remove
STINNER Victor added the comment:
I would prefer that _qdecode be left alone.
Ok, I leaved these symbols unchanged in Lib/email/utils.py even if they are not
used:
--
from quopri import decodestring as _qdecode
from email.encoders import _bencode, _qencode
--
--
Changes by STINNER Victor victor.stin...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20976
___
Barry A. Warsaw added the comment:
On Mar 20, 2014, at 08:29 AM, STINNER Victor wrote:
from quopri import decodestring as _qdecode
from email.encoders import _bencode, _qencode
AFAICT, _qdecode is only used in email/messages.py, so perhaps it's better to
import it there and remove it from
R. David Murray added the comment:
Well, one reason is I was afraid mailman might be using them. So if you are
cool with it, that removes that objection.
The other reason was that it seemed they were being used from utils on
purpose, as a design thing. I did not take the time to do a full
STINNER Victor added the comment:
Barry, David: It's up to you. I'm done with this issue, but you can drop more
unused import if you want. Since I don't know well the email module, I don't
want to be responsible of breaking it :-)
--
___
Python
Barry A. Warsaw added the comment:
On Mar 20, 2014, at 01:32 PM, R. David Murray wrote:
Well, one reason is I was afraid mailman might be using them. So if you are
cool with it, that removes that objection.
Nope, neither the 2.1 or 3.0 code uses those methods AFAICT.
The other reason was
R. David Murray added the comment:
Sure.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20976
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from STINNER Victor:
I ran pyflakes on Python 3.5. Attached patch removes unused imports.
Sometimes, it's tricky to decide if an import is useless or if it is part of
the API.
Strange example using import to define a method!
---
class Message:
...
def get_charsets(self,
Berker Peksag added the comment:
Here's an alternative patch for the tarfile module.
--
nosy: +berker.peksag, serhiy.storchaka
stage: - patch review
Added file: http://bugs.python.org/file34513/issue20976_tarfile.diff
___
Python tracker
STINNER Victor added the comment:
IMO issue20976_tarfile.diff is useless.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20976
___
___
Serhiy Storchaka added the comment:
LGTM. But for _qdecode you should ask RDM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20976
___
___
R. David Murray added the comment:
I would prefer that _qdecode be left alone.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20976
___
___
15 matches
Mail list logo
