[issue21269] Provide args and kwargs attributes on mock call objects

Karthikeyan Singaravelan added the comment: Thanks @kakshay for the patch. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker _

[issue21269] Provide args and kwargs attributes on mock call objects

Chris Withers added the comment: New changeset b0df45e55dc8304bac0e3cad0225472b84190964 by Chris Withers (Kumar Akshay) in branch 'master': bpo-21269: Provide args and kwargs attributes on mock call objects GH11807 https://github.com/python/cpython/commit/b0df45e55dc8304bac0e3cad0225472b84190

[issue21269] Provide args and kwargs attributes on mock call objects

Kumar Akshay added the comment: ping..😬 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue21269] Provide args and kwargs attributes on mock call objects

Karthikeyan Singaravelan added the comment: This feels safer to me with respect to backwards compatibility and also that it might be easier to backport this to mock on GitHub which works with Python 2.7. I have less knowledge on difference between tuple and namedtuple internals so I might be

[issue21269] Provide args and kwargs attributes on mock call objects

Rémi Lapeyre added the comment: @xtreak, couldn't we have made `_Call` inherit from namedtuple to achieve a similar result (albeit the handling of name would be weird)? -- ___ Python tracker

[issue21269] Provide args and kwargs attributes on mock call objects

Rémi Lapeyre added the comment: I like this patch, working with calls often feels weird and this change simplify attribute access. -- nosy: +remi.lapeyre ___ Python tracker __

[issue21269] Provide args and kwargs attributes on mock call objects

Kumar Akshay added the comment: Thanks @xtreak! I've added a PR with the following API ➜ cpython git:(fix-issue-21269) ✗ ./python.exe Python 3.8.0a0 (heads/fix-issue-21269-dirty:2433a2ab70, Feb 10 2019, 14:24:54) [Clang 10.0.0 (clang-1000.10.44.4)] on darwin Type "help", "copyright", "credits"

[issue21269] Provide args and kwargs attributes on mock call objects

Change by Kumar Akshay : -- keywords: +patch, patch, patch pull_requests: +11819, 11820, 11821 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue21269] Provide args and kwargs attributes on mock call objects

Change by Kumar Akshay : -- keywords: +patch pull_requests: +11819 stage: needs patch -> patch review ___ Python tracker ___ ___ Pyt

[issue21269] Provide args and kwargs attributes on mock call objects

Change by Kumar Akshay : -- keywords: +patch, patch pull_requests: +11819, 11820 stage: needs patch -> patch review ___ Python tracker ___ _

[issue21269] Provide args and kwargs attributes on mock call objects

Karthikeyan Singaravelan added the comment: @kakshay, I am not working on it so feel free to pick it up. I stumbled upon this while looking into mock issues and I just posted a patch to gather API feedback. I guess it would be helpful if someone confirms it would be a good addition so that t

[issue21269] Provide args and kwargs attributes on mock call objects

Kumar Akshay added the comment: Hey @xtreak, if you're not working on this, can I submit the patch? -- nosy: +kakshay ___ Python tracker ___ __

[issue21269] Provide args and kwargs attributes on mock call objects

Karthikeyan Singaravelan added the comment: args and kwargs property can be introduced on the call object to return the args and kwargs stored in the tuple. Currently wrapping call object with tuple can get a tuple of args and kwargs but a property would be helpful. A first attempt patch on t

[issue21269] Provide args and kwargs attributes on mock call objects

Changes by Michael Foord : -- assignee: -> michael.foord components: +Library (Lib) nosy: +kushal.das stage: -> needs patch type: -> behavior versions: +Python 3.5 ___ Python tracker

[issue21269] Provide args and kwargs attributes on mock call objects

New submission from Michael Foord: The unittest.mock.call object could have args/kwargs attributes to easily access the arguments it was called with. -- messages: 216585 nosy: michael.foord priority: normal severity: normal status: open title: Provide args and kwargs attributes on mock