Jeroen Ruigrok van der Werven asmo...@in-nomine.org added the comment:
What do we want to do with this one, because it is now seems out of
scope for documentation given the changes Gerhard implemented.
--
nosy: +asmodai
___
Python tracker
Georg Brandl ge...@python.org added the comment:
Looks like that's the case.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2127
___
A.M. Kuchling [EMAIL PROTECTED] added the comment:
vdupras's test case now passes with Python 2.6; we should apply
the patch to the test suite, though. We could ask Barry if he wants to
apply it to 2.6rc, or adding the test can wait until 2.7.
--
nosy: +akuchling
Gerhard Häring [EMAIL PROTECTED] added the comment:
Can we close this now? Did you try out a Python2.6 or Python 3.0 beta?
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2127
___
Gerhard Häring [EMAIL PROTECTED] added the comment:
The implementation in SVN should in the meatntime behave like you expect
now. Look for database_utf8 = PyUnicode_AsUTF8String(database); in
connection.c to see the implementation.
__
Tracker [EMAIL PROTECTED]
Amaury Forgeot d'Arc added the comment:
Sorry, my patch corrected only sqlite3.Connection().
I join a new version, which also changes sqlite3.connect().
By the way, the test should test that the file is created with the
correct name. A call to os.stat() could be enough.
Added file:
Changes by Amaury Forgeot d'Arc:
Removed file: http://bugs.python.org/file9474/sqlite_connect.diff
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2127
__
___
Python-bugs-list
Virgil Dupras added the comment:
Ok then, we need a test for this. Patch attached.
However, I don't know if I applied Amaury's patch wrong or if I miss a
./configure option or something, but even with the patch, the test fails.
Another thing: Why isn't the sqlite3 test suite a part of
Gerhard Häring added the comment:
I didn't try the patch out, yet. But I'd instead try to just open
u:memory instead.
Also, in Lib/test/test_sqlite.py the sqlite tests are started. They are
of course run as part of the Python test suite.
__
Tracker [EMAIL
Virgil Dupras added the comment:
u':memory:'? That already worked before the patch because the implicit
encoding with 'ascii' does not bump into any non-ascii character. Nope,
one has to call connect with a filename containing non-ascii characters.
__
Tracker
Changes by Gerhard Häring:
--
nosy: +ghaering
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2127
__
___
Python-bugs-list mailing list
Unsubscribe:
Gerhard Häring added the comment:
I'll assign this one to me. The sqlite3 module cannot be just
refreshed with the externally maintained pysqlite, I'll have to do
merging anyway. Don't worry here ;-)
--
assignee: - ghaering
keywords: +easy
priority: - low
severity: normal - minor
Amaury Forgeot d'Arc added the comment:
IMO, connect() should accept unicode strings, and encode them to utf-8
when calling the C function.
Patch attached.
--
nosy: +amaury.forgeotdarc
Added file: http://bugs.python.org/file9474/sqlite_connect.diff
__
Virgil Dupras added the comment:
Shouldn't we apply this patch directly on pysqlite? Any change made to
the sqlite3 module will be overwritten in the next refresh, right?
Anyway, I'm not 100% sure, but it might already be fixed:
http://www.initd.org/tracker/pysqlite/changeset/452
So, maybe
Amaury Forgeot d'Arc added the comment:
So, maybe create a ticket to use the latest version of pysqlite?
I don't think so. While the change you are pointing to does deal with
the same problem, the base versions seems to have substantial differences.
I still prefer my patch.
Changes by Benjamin Peterson:
--
nosy: +georg.brandl
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2127
__
___
Python-bugs-list mailing list
Unsubscribe:
Virgil Dupras added the comment:
+1 I've been pulling my hair off over this one too. Try this on win32:
Python 2.5.1 (r251:54863, Apr 18 2007, 08:51:08) [MSC v.1310 32 bit (Intel)] on
win32
Type help, copyright, credits or license for more information.
import os
os.mkdir(u'foo\xe9')
import
New submission from Damien Elmes:
The docs on http://docs.python.org/lib/sqlite3-Module-Contents.html
should mention that the connection string should always be UTF-8,
regardless of the encoding system of the underlying filesystem. See the
'note to windows users' on
18 matches
Mail list logo
