Steve Dower added the comment:
No current reasons I'm aware of (apart from not having a working up-to-date
Windows buildbot right now - blocked on #23524) so I'd say go ahead. Pull it
out and see what breaks.
The fact that the comment says pycapsule.o and not pycapsule.obj probably
means
Larry Hastings added the comment:
You give me too much credit. I'm the chimp who put it there in the first
place. Though, admittedly, it was a copypaste job based on the ancient
CObject.
My guess is this was very helpful in 1.4, or something. ;-)
--
Roundup Robot added the comment:
New changeset b22755f8ab5f by Larry Hastings in branch 'default':
Issue #21293: Remove unnecessary capsule hack.
https://hg.python.org/cpython/rev/b22755f8ab5f
--
nosy: +python-dev
___
Python tracker
Larry Hastings added the comment:
Yeah, I went ahead and checked this in. I'm living life on the *edge*.
To the EXTREME!
--
assignee: - larry
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker
Nick Coghlan added the comment:
I'm inclined to suggest you try removing it and see what happens on the
buildbots.
I remember we used to have a few interesting challenges at my old job
convincing Visual Studio that we really were using a type definition and we
should export it from the DLL.
Mark Lawrence added the comment:
I've taken a bit of a liberty and picked the names of the last three guys
who've worked on this file as I assume they're best qualified to comment.
--
nosy: +BreamoreBoy, haypo, ncoghlan, pitrou
___
Python tracker
New submission from Larry Hastings:
I noticed this code in Objects/object.c today:
/* Hack to force loading of pycapsule.o */
PyTypeObject *_PyCapsule_hack = PyCapsule_Type;
What is this doing? Note that PyCapsule_Type is referred to inside
_Py_ReadyTypes(), so there's already a
