Eric Snow added the comment:
Awesome. Thanks Tim.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21319
___
___
Python-bugs-list mailing list
Tim Golden added the comment:
Turns out to be non-issue after all! I was working through the import code for
other reasons and noticed that the WindowsRegistryFinder was there. I'll spare
you the complications of debugging the _bootstrap part of import, but basically
the code in
Steve Dower added the comment:
I've seen some module paths be registered there, but no, it doesn't really get
used much (maybe because it's been broken?) os.name is certainly the right test
here.
FWIW, I'd rather be prioritising file system over registry for finding packages
anyway. It makes
Paul Moore added the comment:
I think the main (only?) user of having sys.path entries in the registry is
pywin32. It might be worth asking them if they can switch to a more mainstream
approach, and then maybe the whole registry finder thing can be removed
completely.
--
nosy:
Tim Golden added the comment:
I think they stopped using them a while back in favour of a pywin32.pth
file.
I don't think I even knew you could use the registry for sys.path.
If no-one's shouted since the changes to importlib (which was 3.3?) I
think we can quietly drop this and hope no-one
Tim Golden added the comment:
Adding Mark Hammond in case I'm wrong about the (lack of) impact on pywin32
--
nosy: +mhammond
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21319
___
Mark Lawrence added the comment:
Just making sure our Windows people are aware of this issue.
--
components: +Windows
nosy: +BreamoreBoy, steve.dower, tim.golden, zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21319
New submission from Eric Snow:
For #14578 we added WindowsRegistryFinder to importlib and try adding it to
sys.meta_path during bootstrap (see bd58c421057c).
I happened to notice that in _install() in Lib/importlib/_bootstrap.py we check
os.__name__. Shouldn't it be os.name? os.__name__ is
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
versions: +Python 3.3, Python 3.4, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21319
___
