Roundup Robot added the comment:
New changeset ab369d809200 by Berker Peksag in branch 'default':
Issue #21391: Use os.path.abspath in the shutil module.
https://hg.python.org/cpython/rev/ab369d809200
--
nosy: +python-dev
___
Python tracker
Berker Peksag added the comment:
Done. Thanks for the reviews!
--
resolution: - fixed
stage: needs patch - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21391
Serhiy Storchaka added the comment:
I'm for get rid of from import without deprecation. Definitely this is not
part of API.
--
nosy: +serhiy.storchaka
stage: commit review - needs patch
___
Python tracker rep...@bugs.python.org
Changes by Berker Peksag berker.pek...@gmail.com:
--
assignee: - berker.peksag
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21391
___
___
Changes by Berker Peksag berker.pek...@gmail.com:
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21391
___
Eric V. Smith added the comment:
Shouldn't the existing calls to abspath() be changed to os.path.abspath()? Or
are both patches meant to be applied? I don't think the first patch applies
cleanly any more.
In any event: the deprecation and test look good to me. So assuming we get rid
of the
Eric V. Smith added the comment:
Now that I think about it, maybe we don't need a deprecation warning.
http://legacy.python.org/dev/peps/pep-0008/#public-and-internal-interfaces
says:
Imported names should always be considered an implementation detail. Other
modules must not rely on indirect
R. David Murray added the comment:
I'd prefer to get rid of it, otherwise we might get requests to add all the
other os.path functions to the shutil namespace, and I don't think having that
kind of more than one way to do it serves anyone. I suppose we'll have to
deprecate it first if we do
Berker Peksag added the comment:
Here is a patch to deprecate the shutil.abspath function.
--
nosy: +berker.peksag
Added file: http://bugs.python.org/file35272/issue21391.diff
___
Python tracker rep...@bugs.python.org
