Eryk Sun added the comment:
I added an updated implementation of windows_helper.py to the dependency
bpo-22080.
--
components: +Windows
nosy: +paul.moore
versions: +Python 3.10, Python 3.8, Python 3.9 -Python 3.5
___
Python tracker
Claudiu Popa added the comment:
Hello,
Can anyone review the last patch? Hopefully it is the final version, since the
beta is really at the corner and I definitely would like to have this in 3.5.
--
___
Python tracker rep...@bugs.python.org
Claudiu Popa added the comment:
Thank you for the review. The new patch uses the name UnLoadKey for the API.
--
Added file: http://bugs.python.org/file38481/issue21518_6.patch
___
Python tracker rep...@bugs.python.org
Martin v. Löwis added the comment:
The naming of the function needs discussion. I think it should be UnLoadKey, as
the API function behind it is RegUnLoadKey (not RegUnloadKey). It may be
illogical(*) that the function is called that way in the API, but it would add
confusion if Python called
Changes by Claudiu Popa pcmantic...@gmail.com:
Added file: http://bugs.python.org/file38382/issue21518_5.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21518
___
Claudiu Popa added the comment:
Ups, the last patch included an extra file.
--
Added file: http://bugs.python.org/file37819/issue21518_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21518
Changes by Claudiu Popa pcmantic...@gmail.com:
Added file: http://bugs.python.org/file37820/issue21518_4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21518
___
Claudiu Popa added the comment:
The new patch drops the weird error dance from test_unload_key, it seems to
work without it, I don't remember how it failed without it.
--
Added file: http://bugs.python.org/file37742/issue21518_2.patch
___
Python
Claudiu Popa added the comment:
Is there something I can do to move this forward?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21518
___
___
Changes by Claudiu Popa pcmantic...@gmail.com:
--
dependencies: +Add windows_helper module helper
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21518
___
Claudiu Popa added the comment:
Here's the patch with only the change for winreg.UnloadKey. I'll have the patch
with windows_helper soon.
--
Added file: http://bugs.python.org/file35907/winreg_unload_key.patch
___
Python tracker
Zachary Ware added the comment:
I'd like to see the windows_helper.py part of the patch split into its own
issue, and someone more qualified than I to review it (though I'll learn what I
can and give it a shot if nobody else can). The new issue should also try to
use the new windows_helper
Claudiu Popa added the comment:
Sure, that sounds good.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21518
___
___
Python-bugs-list mailing
Claudiu Popa added the comment:
Any type of feedback will be appreciated.
--
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21518
___
Claudiu Popa added the comment:
Attached a new version of the patch which cleanups properly after tests.
--
Added file: http://bugs.python.org/file35618/issue21518_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21518
Claudiu.Popa added the comment:
This version of the patch skips the test if the privileges can't be acquired.
--
Added file: http://bugs.python.org/file35285/issue21518.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21518
eryksun added the comment:
ctypes LibraryLoader instances cache CDLL/WinDLL instances, which cache
function pointers. Using the global ctypes.cdll and ctypes.windll loaders can
lead to conflicting definitions for restype, argtypes, and errcheck. I suggest
using a private LibraryLoader in
Claudiu.Popa added the comment:
Thanks. Here's the updated version. Also, I only tested it on Windows 8.1. I'll
try to find another machine with an older OS for testing it.
--
Added file: http://bugs.python.org/file35288/issue21518_1.patch
___
New submission from Claudiu.Popa:
Hello. While working on issue8579, I noticed that there is no way to detach a
key from the registry, loaded with LoadKey function. The attached patch exposes
RegUnLoadKeyW as winreg.UnloadKey. Also, this patch adds a new script in the
test folder,
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +steve.dower, tim.golden, zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21518
___
Claudiu.Popa added the comment:
It needs administrator elevation for running the test. I'll update the patch to
skip the test if the user doesn't have elevation.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21518
21 matches
Mail list logo
