[issue21520] Erroneous zipfile test failure if the string 'bad' appears in pwd

2015-05-08 Thread Larry Hastings
Larry Hastings added the comment: Checked in, with the filter function on a separate line, to 3.4. Also merged into 3.5. -- resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org

[issue21520] Erroneous zipfile test failure if the string 'bad' appears in pwd

2015-05-08 Thread Roundup Robot
Roundup Robot added the comment: New changeset bff966aed6a3 by Larry Hastings in branch '3.4': Issue #21520: test_zipfile no longer fails if the word 'bad' appears https://hg.python.org/cpython/rev/bff966aed6a3 -- nosy: +python-dev ___ Python tracker

[issue21520] Erroneous zipfile test failure if the string 'bad' appears in pwd

2014-08-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The line is too long. It would be better to extract a filter as regular function. Otherwise LGTM. -- nosy: +serhiy.storchaka stage: needs patch - commit review ___ Python tracker rep...@bugs.python.org

[issue21520] Erroneous zipfile test failure if the string 'bad' appears in pwd

2014-08-14 Thread Ismail Badawi
Changes by Ismail Badawi ism...@badawi.io: -- nosy: +ismail.badawi ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21520 ___ ___ Python-bugs-list

[issue21520] Erroneous zipfile test failure if the string 'bad' appears in pwd

2014-06-11 Thread Larry Hastings
Larry Hastings added the comment: With this patch applied the test passes. (Patch is against 3.4 branch.) Look good? -- keywords: +patch Added file: http://bugs.python.org/file35567/larry.bad.zipfile.1.diff ___ Python tracker

[issue21520] Erroneous zipfile test failure if the string 'bad' appears in pwd

2014-06-11 Thread Ned Deily
Ned Deily added the comment: Yep -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21520 ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21520] Erroneous zipfile test failure if the string 'bad' appears in pwd

2014-05-18 Thread Larry Hastings
New submission from Larry Hastings: If you extract current Python (3.4 or trunk) into a directory, and anywhere in the name of the directory is the string bad, such as /tmp/badtest /home/baddison/src/python then test_write_filtered_python_package() in Lib/test/test_zipfile.py will fail. The

[issue21520] Erroneous zipfile test failure if the string 'bad' appears in pwd

2014-05-18 Thread Georg Brandl
Changes by Georg Brandl ge...@python.org: -- nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21520 ___ ___ Python-bugs-list

[issue21520] Erroneous zipfile test failure if the string 'bad' appears in pwd

2014-05-18 Thread Larry Hastings
Larry Hastings added the comment: Here's an eye-wateringly-thorough description of the bug for the sake of posterity. The test code in question is test_write_filtered_python_package() in Lib/test/test_zipfile.py. This function uses PyZipFile to build a zipfile from the contents of the

[issue21520] Erroneous zipfile test failure if the string 'bad' appears in pwd

2014-05-18 Thread Ned Deily
Ned Deily added the comment: Testing for Lib/test/bad isn't correct either since the test will fail when the tests are run from an installed Python rather than just from a build directory. -- nosy: +ned.deily ___ Python tracker