Changes by R. David Murray rdmur...@bitdance.com:
--
versions: -Python 2.6, Python 3.0
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2170
___
___
R. David Murray rdmur...@bitdance.com added the comment:
Committed in r71414.
--
resolution: - accepted
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2170
___
A.M. Kuchling li...@amk.ca added the comment:
The new version of the code looks all right, so I
think this patch can be applied.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2170
___
R. David Murray rdmur...@bitdance.com added the comment:
Andrew, any objection to my going ahead and applying this patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2170
___
Changes by R. David Murray rdmur...@bitdance.com:
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2170
___
Changes by Brett Cannon br...@python.org:
--
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2170
___
___
Python-bugs-list
Changes by R. David Murray rdmur...@bitdance.com:
Removed file: http://bugs.python.org/file13312/test_minidom.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2170
___
Changes by R. David Murray rdmur...@bitdance.com:
Removed file: http://bugs.python.org/file13352/issue2170.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2170
___
R. David Murray rdmur...@bitdance.com added the comment:
Removed old patches, updated patch to remvoe the unnecessary local
variable assignment (also pushed to launchpad).
--
Added file: http://bugs.python.org/file13374/issue2170.patch
___
Python
Malte Helmert helm...@informatik.uni-freiburg.de added the comment:
Short review: code looks good to me, patch applies cleanly to trunk,
passes tests.
@akuchling: I don't know if you remember, but this rewrite was
originally suggested by you on a bug day some time ago. I think David's
patch is
R. David Murray rdmur...@bitdance.com added the comment:
I checked the speed of the proposed patch, and found that it was
definitely slower than the original code. So I took another look at the
original, and refactored it in a different way: instead of moving the
sibling relinking into a second
Malte Helmert helm...@informatik.uni-freiburg.de added the comment:
I eyeballed the new patch and wonder if the case where text nodes are
collapsed is handled correctly. Assume that self.childNodes contains
nodes [A, B, C], where A and B are non-empty text nodes and C is a
non-text node.
The
R. David Murray rdmur...@bitdance.com added the comment:
You are absolutely right. I will write a test case and fix the patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2170
___
R. David Murray rdmur...@bitdance.com added the comment:
Added several more tests, to validate the sibling link code more, and
fixed the bug.
--
Added file: http://bugs.python.org/file13352/issue2170.patch
___
Python tracker rep...@bugs.python.org
Changes by R. David Murray rdmur...@bitdance.com:
Removed file: http://bugs.python.org/file13349/issue2170.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2170
___
Malte Helmert helm...@informatik.uni-freiburg.de added the comment:
While we're cleaning up:
data = child.data
if not data:
could be
if not child.data:
since data is not used again.
Alternatively, you could use data in place of child.data later on for a
small speed-up, but
Changes by Malte Helmert helm...@informatik.uni-freiburg.de:
Removed file: http://bugs.python.org/file9513/minidom.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2170
___
Malte Helmert helm...@informatik.uni-freiburg.de added the comment:
I removed my original patch which has been superseded by David's patch.
David, I suggest that you also remove test_minidom.patch which is
superseded by your later patch (see http://bugs.python.org/msg77766 for
policy on this).
R. David Murray rdmur...@bitdance.com added the comment:
I have applied the supplied patch to the current trunk, and it passes
the tests. I've also attached a more extensive test case that exercises
the recursion.
--
keywords: +patch
nosy: +bitdancer
Added file:
New submission from Malte Helmert:
In the discussion of #1433694 on the #python-dev channel, it was
observed that the normalize method of minidom.Node could take some
refactoring. A patch is attached.
--
components: XML
files: minidom.diff
messages: 62794
nosy: maltehelmert
severity:
Changes by A.M. Kuchling:
--
assignee: - akuchling
nosy: +akuchling
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2170
__
___
Python-bugs-list mailing list
21 matches
Mail list logo
