Roundup Robot added the comment:
New changeset 3aec776fc796 by Zachary Ware in branch 'default':
Issue #21741: Update 147 test modules to use test discovery.
https://hg.python.org/cpython/rev/3aec776fc796
--
___
Python tracker rep...@bugs.python.org
Changes by Zachary Ware zachary.w...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21741
___
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21741
___
___
Roundup Robot added the comment:
New changeset 706fab0213db by Zachary Ware in branch 'default':
Issue #21741: Add st_file_attributes to os.stat_result on Windows.
http://hg.python.org/cpython/rev/706fab0213db
--
nosy: +python-dev
___
Python tracker
Changes by Zachary Ware zachary.w...@gmail.com:
--
Removed message: http://bugs.python.org/msg220987
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21741
___
Zachary Ware added the comment:
@Terry: This is part of the ongoing effort of issues #16748 and #10967 (and
possibly others). My ultimate goal along those lines is to eradicate
support.run_unittest, and this is a step in that direction.
I think there's enough support here to skip python-dev
Raymond Hettinger added the comment:
My ultimate goal along those lines is to eradicate
support.run_unittest, and this is a step in that direction.
I think there's enough support here to skip python-dev :).
Not really. There is support here for using unittest.main() whereever it fits
and
Zachary Ware added the comment:
Raymond Hettinger added the comment:
I think there's enough support here to skip python-dev :).
Not really. There is support here for using unittest.main()
whereever it fits and cleans-up the code. That is not the same as
saying we can eliminate
Serhiy Storchaka added the comment:
I compared tests output with and without patch and noticed only one significant
difference.
ForkWait is imported in Lib/test/test_wait3.py, Lib/test/test_wait4.py and
Lib/test/test_fork1.py and now it is executed 4 times. Either this class
should be turned
Michael Foord added the comment:
I haven't reviewed the patch in detail, but I've had a scan through and it
looks *great*. A quick and dirty check that it's correct is to compare the
number of tests run before and after the patch - and if the numbers differ
verifying that it's for good
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21741
___
___
R. David Murray added the comment:
+1 from me (after verification), which should probably go without saying since
I'm the one that started this ball rolling by making regrtest work with
unittest discovery :)
I think the potential disruption to existing patches and any forward porting
issues
Serhiy Storchaka added the comment:
Some abstract test classes now are included in testing:
Lib/test/test_calendar.py: MonthCalendarTestCase
Lib/test/test_csv.py: TestCsvBase
Lib/test/test_funcattrs.py: FuncAttrsTest
Lib/test/test_sys_setprofile.py: TestCaseBase
Lib/test/test_telnetlib.py:
Michael Foord added the comment:
Those should be turned into mixins, or someone could implement issue 14534.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21741
___
Raymond Hettinger added the comment:
There are a couple things I really like about this idea:
* In the past, we've had cases of TestXXX classes being omitted, so chunks of
the test suite weren't being run. You patch will fix that and let test
discovery just work.
* The code is shorter, more
Zachary Ware added the comment:
Here's a diff against 3.4 produced by the script. Warning: it's rather large.
$ hg diff --stat
[...]
162 files changed, 199 insertions(+), 942 deletions(-)
--
keywords: +patch
Added file: http://bugs.python.org/file35616/issue21741.diff
Terry J. Reedy added the comment:
You might add a brief description of why this is good idea, or link to such a
discussion.
I am +1 on the idea, but a pydev discussion might be needed.
How did you test the patch? I don't think that passing the same tests in
non-verbose mode is good enough,
New submission from Zachary Ware:
Attached is a quick-and-dirty script that converts a large chunk of the test
suite away from support.run_unittest and test_main to unittest test discovery
and unittest.main. Several files are marked as 'do not touch' due to various
issues that the script
18 matches
Mail list logo
