R. David Murray added the comment:
What is the reason for using the conditional approach rather than a skip
decorator? Does it not work in this context, or is it just that you copied the
existing approach? It's fine either way, but I'm curious.
--
Berker Peksag added the comment:
Does it not work in this context
Yes, it doesn't work after 34d65746d5ca because LOCK_TYPES is an empty dict
(test_util.test_both() can't find the 'Frozen' and 'Source' keys in it) when
Python is built without threads.
--
Changes by Berker Peksag berker.pek...@gmail.com:
--
assignee: - berker.peksag
versions: -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21755
___
Roundup Robot added the comment:
New changeset b88525a8c01d by Berker Peksag in branch 'default':
Issue #21755: Skip {Frozen,Source}_DeadlockAvoidanceTests tests when
http://hg.python.org/cpython/rev/b88525a8c01d
--
nosy: +python-dev
___
Python
Changes by Berker Peksag berker.pek...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21755
___
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21755
___
___
Berker Peksag added the comment:
See also
http://buildbot.python.org/all/builders/AMD64%20Fedora%20without%20threads%203.x/builds/6779/steps/test/logs/stdio
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21755
New submission from Berker Peksag:
==
ERROR: test.test_importlib.test_locks (unittest.loader.ModuleImportFailure)
--
Traceback (most recent call last):
File
