Changes by R. David Murray rdmur...@bitdance.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21800
___
Roundup Robot added the comment:
New changeset 195343b5e64f by R David Murray in branch 'default':
#21800: Add RFC 6855 support to imaplib.
https://hg.python.org/cpython/rev/195343b5e64f
--
nosy: +python-dev
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
Thanks, Maciek (and Milan).
I tweaked your patch slightly (mostly doc changes...I moved the discussion of
the utf8 RFC into the enable method only, and added back the docs for
utf8_enabled). I made some review comments about the changes other than that
doc
Maciej Szulik added the comment:
David, I've changed according to your suggestion, appreciate review.
--
Added file: http://bugs.python.org/file39324/issue21800.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21800
Maciej Szulik added the comment:
Yes, I can update that (that IMAP testing bug -
http://bugs.python.org/issue22137, is taking me longer than I expected it ;)).
I just want to make sure if I understand you correctly what's needs to be done
is removing the utf8_enable code from init, we will
R. David Murray added the comment:
An explicit call to enable with an argument string that contains 'UTF8=ACCEPT'.
I did not go far enough through the BNF to determine if enable can be passed
more than one capability at a time, but I suspect it can. In which case we
should factor out the
R. David Murray added the comment:
Well, the problem with that is that we then have to parse the capability to see
if it is utf8 that is being enabled. I don't like that as an API, it feels
fragile. Since capabilities cannot later be disabled, there's no functional
reason to keep it
Maciej Szulik added the comment:
David I did the review and there's one thing that worries me the most, actually
two:
1. changing the usual meaning of None in the IMAP's __init__ method, where None
has the same meaning as True, where I think it should be the opposite.
2. I'm not sure we want
R. David Murray added the comment:
Here is an updated patch based on Milan's work, including docs. I've tweaked
the API slightly: no dedicated method for doing the enable (instead it is
inlined in authenticate), I added 'enable' to the exposed API (with a doc
caveat about not using it for
Changes by Håkan Lövdahl hlovd...@gmail.com:
--
nosy: +Håkan Lövdahl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21800
___
___
Python-bugs-list
Mark Lawrence added the comment:
The patch contains changes to code and tests have been added so can we have a
formal review please.
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21800
New submission from Milan Oberkirch:
I made a patch implementing the following changes to the IMAP4 class:
- add a method 'enable_UTF8_accept()' sending ENABLE UTF8=ACCEPT to the
server and setting internal encoding to UTF-8
- use the UTF8 extencion in the 'append()' method if the internal
Changes by Jim Jewett jimjjew...@gmail.com:
--
stage: - needs patch
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21800
___
Changes by Milan Oberkirch milan...@oberkirch.org:
--
components: email
nosy: barry, jesstess, pitrou, r.david.murray, zvyn
priority: normal
severity: normal
status: open
title: Implement RFC 6855 (IMAP Support for UTF-8) in imaplib.
versions: Python 3.5
14 matches
Mail list logo
