Serhiy Storchaka added the comment:
Both issues are fixed.
--
assignee: - serhiy.storchaka
dependencies: -Check path arguments of os functions for null character
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21859
___
___
Python-bugs-list
STINNER Victor added the comment:
What's the status of the patch? Is it ready to be commited?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21859
___
Serhiy Storchaka added the comment:
Restored first os.fstat() (however it now is redundant) and addressed most
other Victor's comments.
In general I prefer EAFP over BDFL, and often except AttributeError looks
better to me than getattr().
--
Added file:
Changes by Hynek Schlawack h...@ox.cx:
--
nosy: -hynek
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21859
___
___
Python-bugs-list mailing list
STINNER Victor added the comment:
I opened the issue #23752: Cleanup io.FileIO.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21859
___
___
Serhiy Storchaka added the comment:
Updated to the tip (added the closefd attribute in repr). os.fstat() is now
called only once in the constructor.
--
Added file: http://bugs.python.org/file38651/pyio_fileio_7.patch
___
Python tracker
STINNER Victor added the comment:
New issue #23754: Add a new os.read_into() function to avoid memory copies.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21859
___
Serhiy Storchaka added the comment:
Synchronized with the tip. _io.FileIO now behave same as _pyio,FileIO when
there is a NUL in name.
--
Added file: http://bugs.python.org/file36782/pyio_fileio_6.patch
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Next iteration of the patch addressed Victor's and Akira's comments.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21859
___
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file36183/pyio_fileio_5.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21859
___
Serhiy Storchaka added the comment:
Next iteration of the patch addressed Victor's comments.
--
Added file: http://bugs.python.org/file36032/pyio_fileio_4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21859
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21859
___
___
Python-bugs-list
Changes by Piotr Dobrogost p...@bugs.python.dobrogost.net:
--
nosy: +piotr.dobrogost
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21859
___
___
Serhiy Storchaka added the comment:
Many thanks Victor for your review. Updated patch addresses your comments. It
also fixes debugging remnants in test_file_eintr.
--
Added file: http://bugs.python.org/file35871/pyio_fileio_3.patch
___
Python
Serhiy Storchaka added the comment:
Updated patch has included recent changes from C implementation (issue21679 and
issue21090).
--
Added file: http://bugs.python.org/file35858/pyio_fileio_2.patch
___
Python tracker rep...@bugs.python.org
New submission from Serhiy Storchaka:
Proposed patch adds Python implementation of FileIO in _pyio. This will help to
make io and _pyio dependency on _io optional (issue17984).
--
components: IO, Library (Lib)
files: pyio_fileio.patch
keywords: patch
messages: 221449
nosy: alex,
17 matches
Mail list logo