[issue21905] RuntimeError in pickle.whichmodule when sys.modules if mutated

Olivier Grisel added the comment: No problem. Thanks Antoine for the review! -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue21905] RuntimeError in pickle.whichmodule when sys.modules if mutated

Roundup Robot added the comment: New changeset 86ba3bdfac15 by Antoine Pitrou in branch '3.4': Issue #21905: Avoid RuntimeError in pickle.whichmodule() when sys.modules is mutated while iterating. https://hg.python.org/cpython/rev/86ba3bdfac15 New changeset d748a3503ad5 by Antoine Pitrou in bra

[issue21905] RuntimeError in pickle.whichmodule when sys.modules if mutated

Antoine Pitrou added the comment: Sorry for the delay, Olivier. Your patch is now pushed. Thank you! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker __

[issue21905] RuntimeError in pickle.whichmodule when sys.modules if mutated

Olivier Grisel added the comment: New version of the patch to add an inline comment. -- Added file: http://bugs.python.org/file35841/pickle_whichmodule_20140703.patch ___ Python tracker

[issue21905] RuntimeError in pickle.whichmodule when sys.modules if mutated

Antoine Pitrou added the comment: Sounds fine, but you should at least add a comment explaining the list() call. -- nosy: +alexandre.vassalotti, pitrou stage: -> patch review type: crash -> behavior ___ Python tracker

[issue21905] RuntimeError in pickle.whichmodule when sys.modules if mutated

New submission from Olivier Grisel: `pickle.whichmodule` performs an iteration over `sys.modules` and tries to perform `getattr` calls on those modules. Unfortunately some modules such as those from the `six.moves` dynamic module can trigger imports when calling `getattr` on them, hence mutati