[issue21916] Create unit tests for turtle textonly

Roundup Robot added the comment: New changeset 5c1befa401ca by Serhiy Storchaka in branch '3.5': Issue #21916: Added more tests for the turtle module. https://hg.python.org/cpython/rev/5c1befa401ca New changeset 41fa38ea46ba by Serhiy Storchaka in branch '2.7': Issue #21916: Added more tests

[issue21916] Create unit tests for turtle textonly

Serhiy Storchaka added the comment: Thank you for your patches Jelle. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue21916] Create unit tests for turtle textonly

Jelle Zijlstra added the comment: Thanks, this patch addresses your comments. -- Added file: http://bugs.python.org/file43228/issue21916-more-cr.patch ___ Python tracker

[issue21916] Create unit tests for turtle textonly

Serhiy Storchaka added the comment: Thank you Jelle. Added minor comments on Rietveld. -- stage: needs patch -> patch review ___ Python tracker ___

[issue21916] Create unit tests for turtle textonly

Jelle Zijlstra added the comment: Patch tests constructor, repr, equality checks, and pickling on Vec2D. -- Added file: http://bugs.python.org/file43216/issue21916-more.patch ___ Python tracker

[issue21916] Create unit tests for turtle textonly

Jelle Zijlstra added the comment: Thanks for merging it in. I'll add the additional tests. -- ___ Python tracker ___

[issue21916] Create unit tests for turtle textonly

Serhiy Storchaka added the comment: Jelle, do you want to add tests the constructor, repr and pickling of Vec2D? -- stage: commit review -> needs patch ___ Python tracker

[issue21916] Create unit tests for turtle textonly

Roundup Robot added the comment: New changeset f0b94cfcea45 by Serhiy Storchaka in branch '2.7': Issue #21916: Added tests for the turtle module. https://hg.python.org/cpython/rev/f0b94cfcea45 New changeset 3b9e96440a70 by Serhiy Storchaka in branch '3.5': Issue #21916: Added tests for the

[issue21916] Create unit tests for turtle textonly

Serhiy Storchaka added the comment: Nice. LGTM. -- stage: patch review -> commit review versions: +Python 2.7 ___ Python tracker ___

[issue21916] Create unit tests for turtle textonly

Jelle Zijlstra added the comment: Thanks for your comments. Added a patch addressing your comments. -- Added file: http://bugs.python.org/file43202/issue21916-cr2.patch ___ Python tracker

[issue21916] Create unit tests for turtle textonly

Serhiy Storchaka added the comment: Added few minor comments on Rietveld. Please use more complex example for invalid config. Add valid lines before and after an invalid line. -- versions: +Python 3.6 -Python 3.4 ___ Python tracker

[issue21916] Create unit tests for turtle textonly

Jelle Zijlstra added the comment: This patch removes the unrelated XML changes and addresses most of the code review comments. -- nosy: +Jelle Zijlstra Added file: http://bugs.python.org/file43199/issue21916-cr.patch ___ Python tracker

[issue21916] Create unit tests for turtle textonly

Tim Golden added the comment: Tests failed on Windows probably because of NamedTemporaryFile -- nosy: +tim.golden ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21916 ___

[issue21916] Create unit tests for turtle textonly

arachnegl added the comment: Thanks Tim for testing on Windows and suggesting the change. -- nosy: +gregorylo...@gmail.com versions: +Python 3.4 Added file: http://bugs.python.org/file39458/test_turtle.patch ___ Python tracker rep...@bugs.python.org

[issue21916] Create unit tests for turtle textonly

Tim Golden added the comment: @RDM I'm sitting with Greg at a London Python session and we've run through these tests on 3.4/3.5. I know you were reviewing this code at PyCon. Are you happy for me to commit from here? -- ___ Python tracker

[issue21916] Create unit tests for turtle textonly

Serhiy Storchaka added the comment: Added comments on Rietveld. It looks the patch includes changes for non-relevant files. -- type: - enhancement ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21916

[issue21916] Create unit tests for turtle textonly

Serhiy Storchaka added the comment: I'm making a review. -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21916 ___ ___

[issue21916] Create unit tests for turtle textonly

R. David Murray added the comment: Yes, I don't need to be involved further (unless you need help from me on something :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21916 ___

[issue21916] Create unit tests for turtle textonly

Tim Golden added the comment: Serhiy's offered a review and we can take it from here. :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21916 ___

[issue21916] Create unit tests for turtle textonly

Gregory Loyse added the comment: Thanks David for your review! I have added a new patch in response. Note the file has a new name -- Added file: http://bugs.python.org/file39018/test_turtle.patch ___ Python tracker rep...@bugs.python.org

[issue21916] Create unit tests for turtle textonly

Gregory Loyse added the comment: Patch reviewed. Looks good. This patch includes some amendments for readablity and new tests. -- nosy: +arachnegl Added file: http://bugs.python.org/file38950/test_turtle_textonly.patch ___ Python tracker

[issue21916] Create unit tests for turtle textonly

R. David Murray added the comment: I made some review comments on ways to use test.support and test.subTest to simplify the code and make it even clearer. Also, I suggest not using Mock unless necessary (see review comments). -- nosy: +r.david.murray

[issue21916] Create unit tests for turtle textonly

Changes by Jessica McKellar jesst...@mit.edu: -- keywords: +needs review stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21916 ___

[issue21916] Create unit tests for turtle textonly

New submission from ingrid: Non-gui tests for turtle that Lita and I wrote. -- components: Tests files: test_turtle_textonly.patch keywords: patch messages: 82 nosy: ingrid, jesstess priority: normal severity: normal status: open title: Create unit tests for turtle textonly