[issue21931] Nonsense errors reported by msilib.FCICreate for bad argument

Changes by Zachary Ware : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue21931] Nonsense errors reported by msilib.FCICreate for bad argument

Zachary Ware added the comment: It's a simple enough fix, so I went ahead and committed it. Thanks for the patch! I've created issue24224 to track the addition of tests to test_msilib (for more than just this issue). -- resolution: fixed -> stage: resolved -> patch review status: cl

[issue21931] Nonsense errors reported by msilib.FCICreate for bad argument

Roundup Robot added the comment: New changeset 41281737d71a by Zachary Ware in branch '3.4': Issue #21931: Fix error handling in msilib.FCICreate(). https://hg.python.org/cpython/rev/41281737d71a New changeset cb0d1d86215e by Zachary Ware in branch 'default': Closes #21931: Merge with 3.4 https:

[issue21931] Nonsense errors reported by msilib.FCICreate for bad argument

Zachary Ware added the comment: I'll try to have a look at this later today, but unfortunately can't guarantee anything (I don't know C, MSI, or _msi very well). -- ___ Python tracker __

[issue21931] Nonsense errors reported by msilib.FCICreate for bad argument

Jeffrey Armstrong added the comment: I thought, while I'm here reporting another bug, I'd bump this once more. There is a patch here, and it corrects clearly broken code. Should I mark this as "won't fix?" -- ___ Python tracker

[issue21931] Nonsense errors reported by msilib.FCICreate for bad argument

Martin v. Löwis added the comment: Right, the entire patch might be processed in 30 minutes. I won't have these 30 minutes any time soon. -- ___ Python tracker ___ _

[issue21931] Nonsense errors reported by msilib.FCICreate for bad argument

Jeffrey Armstrong added the comment: There's not much to look into. If the Python function encounters an argument error, it returns an uninitialized integer as an "error code." This patch fixes incorrect C code, nothing more. -- ___ Python tracker

[issue21931] Nonsense errors reported by msilib.FCICreate for bad argument

Martin v. Löwis added the comment: I haven't had any time to work on Python in the last year, so it may take some more time for me to look into this. -- ___ Python tracker ___ _

[issue21931] Nonsense errors reported by msilib.FCICreate for bad argument

Changes by Ezio Melotti : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21931] Nonsense errors reported by msilib.FCICreate for bad argument

Jeffrey Armstrong added the comment: Is this patch going to be accepted? It fixes actual incorrect code in msilib, and it seems to have stagnated -- ___ Python tracker ___

[issue21931] Nonsense errors reported by msilib.FCICreate for bad argument

R. David Murray added the comment: mslib doesn't have many tests, but it looks like it would be easy enough to add one for this? -- nosy: +r.david.murray ___ Python tracker ___

[issue21931] Nonsense errors reported by msilib.FCICreate for bad argument

Jeffrey Armstrong added the comment: Attached a patch. The dangers of using goto... -- keywords: +patch Added file: http://bugs.python.org/file35935/_msi.3.4.0.patch ___ Python tracker

[issue21931] Nonsense errors reported by msilib.FCICreate for bad argument

Ezio Melotti added the comment: Do you want to propose a patch? -- components: +Windows nosy: +ezio.melotti, loewis, steve.dower, tim.golden, zach.ware stage: -> needs patch ___ Python tracker

[issue21931] Nonsense errors reported by msilib.FCICreate for bad argument

New submission from Jeffrey Armstrong: The function fcicreate in PC/_msi.c can return nonsense if the list of files passed to msilib.FCICreate does not contains tuples as expected. To replicate, import msilib msilib.FCICreate("test.cab", ["entry.txt"]) The above code will return a ValueError