[issue21951] tcl test change crashes AIX

Serhiy Storchaka added the comment: Thank you Victor for great investigation of this issue. -- ___ Python tracker ___ ___ Python-bugs-

[issue21951] tcl test change crashes AIX

STINNER Victor added the comment: test_tcl now pass on AIX: http://buildbot.python.org/all/builders/PPC64%20AIX%203.x/builds/2592/steps/test/logs/stdio Thanks Serhiy for the fix. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue21951] tcl test change crashes AIX

STINNER Victor added the comment: > Committed these two changes as separate patches. Thanks, it's clearer like that. -- ___ Python tracker ___ __

[issue21951] tcl test change crashes AIX

Serhiy Storchaka added the comment: Committed these two changes as separate patches. -- stage: patch review -> commit review ___ Python tracker ___ __

[issue21951] tcl test change crashes AIX

Roundup Robot added the comment: New changeset ee969a717cb5 by Serhiy Storchaka in branch '2.7': Issue #21951: Use attemptckalloc() instead of ckalloc() in Tkinter. http://hg.python.org/cpython/rev/ee969a717cb5 New changeset 1223c882253f by Serhiy Storchaka in branch '3.4': Issue #21951: Use att

[issue21951] tcl test change crashes AIX

STINNER Victor added the comment: "I'm not sure that tkinter_ckallock.patch is correct." Oh, when I read my message, I realized that I was not explicit enough. It looks like attemptckalloc() can be called with 0 at some places with tkinter_ckallock.patch. But I didn't check carefully, the pat

[issue21951] tcl test change crashes AIX

STINNER Victor added the comment: I'm not sure that tkinter_ckallock.patch is correct. Extract of attemptckalloc() manual page: "If the allocation fails, these functions will return NULL. Note that on some platforms, but not all, attempting to allocate a zero-sized block of memory will also ca

[issue21951] tcl test change crashes AIX

Serhiy Storchaka added the comment: As Victor noted on IRC, ckalloc() panics and doesn't returns NULL in case of error. We should use attemptckalloc() instead. -- stage: needs patch -> patch review Added file: http://bugs.python.org/file36582/tkinter_ckallock.patch

[issue21951] tcl test change crashes AIX

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21951] tcl test change crashes AIX

Serhiy Storchaka added the comment: The patch can be simpler. And there is yet one similar bug, for unicode strings. -- Added file: http://bugs.python.org/file36544/asobj_empty_sequence_2.patch ___ Python tracker _

[issue21951] tcl test change crashes AIX

STINNER Victor added the comment: Thanks David! Your ouput confirms my analysis. asobj_empty_sequence.patch should fix the test on AIX. I read Tcl source code, Tcl_NewListObj() doesn't use the second parameter if the first parameter (length) is zero. -- Added file: http://bugs.python.

[issue21951] tcl test change crashes AIX

David Edelsohn added the comment: $ ./python -m test -v test_tcl == CPython 3.5.0a0 (default:9ab404cdcaa1+, Sep 4 2014, 10:06:33) [GCC 4.8.1] == AIX-1-00F84C0C4C00-powerpc-32bit big-endian == hash algorithm: siphash24 32bit == /home/dje/src/cpython/build/test_python_48694044 Testing with fl

[issue21951] tcl test change crashes AIX

STINNER Victor added the comment: > When the failing test is re-enabled, the _tkinter patch produces the > following output: Thanks. I found and fixed a bug in AsObj() for tuple and list. It looks like ckalloc(size) returns NULL if size is 0. Please update Python, compile and run test_tcl to

[issue21951] tcl test change crashes AIX

Roundup Robot added the comment: New changeset 9ab404cdcaa1 by Victor Stinner in branch 'default': Issue #21951: Fix AsObj() of the _tkinter module: raise MemoryError on memory http://hg.python.org/cpython/rev/9ab404cdcaa1 -- ___ Python tracker

[issue21951] tcl test change crashes AIX

David Edelsohn added the comment: When the failing test is re-enabled, the _tkinter patch produces the following output: test_user_command (test.test_tcl.TclTest) ... Assertion failed: __EX, file /home/dje/src/cpython/Modules/_tkinter.c, line 1277 Fatal Python error: Aborted Current thread 0

[issue21951] tcl test change crashes AIX

Serhiy Storchaka added the comment: As far as I remember, both res and PyErr_Occurred() were NULL. -- ___ Python tracker ___ ___ Pytho

[issue21951] tcl test change crashes AIX

STINNER Victor added the comment: The failing assertion means that the method raised an exception and returned a result, or failed but didn't raised an exception. According to the gdb trace, the function failed (res is NULL). You can display the current exception in gdb using: "print PyErr_Occ

[issue21951] tcl test change crashes AIX

Serhiy Storchaka added the comment: Link to log with a crash: http://buildbot.python.org/all/builders/PPC64%20AIX%203.x/builds/2442/steps/test/logs/stdio -- stage: patch review -> needs patch ___ Python tracker __

[issue21951] tcl test change crashes AIX

Roundup Robot added the comment: New changeset 7de64def6565 by Serhiy Storchaka in branch '2.7': Issue #21951: Temporary skip crashing test_user_command on AIX. http://hg.python.org/cpython/rev/7de64def6565 New changeset 31f4cb1fede9 by Serhiy Storchaka in branch '3.4': Issue #21951: Temporary s

[issue21951] tcl test change crashes AIX

David Edelsohn added the comment: No difference with the patch. The problem is not a a malloc() failure. -- ___ Python tracker ___ ___

[issue21951] tcl test change crashes AIX

Serhiy Storchaka added the comment: May be this patch will help. -- keywords: +patch stage: -> patch review Added file: http://bugs.python.org/file35944/tkinter_nomemory.patch ___ Python tracker __

[issue21951] tcl test change crashes AIX

David Edelsohn added the comment: #5 0x1019bb90 in PyCFunction_Call (func=0x30533b5c, arg=0x305d8ab4, kw=0x0) at Objects/methodobject.c:94 #6 0x1012534c in call_function (pp_stack=0x2ff16144, oparg=2) at Python/ceval.c:4269 94 CHECK_RESULT(res); (gdb) print res $9 = (

[issue21951] tcl test change crashes AIX

David Edelsohn added the comment: > Is following test passed? > check((1,), '1') That test succeeds. > Is CPython crashes when change signature of testfunc? --- a/Lib/test/test_tcl.py Sat Jul 12 18:26:03 2014 +0300 +++ b/Lib/test/test_tcl.py Sun Jul 13 19:21:55 2014 +0300 @@

[issue21951] tcl test change crashes AIX

Serhiy Storchaka added the comment: Is following test passed? check((1,), '1') Is CPython crashes when change signature of testfunc? --- a/Lib/test/test_tcl.py Sat Jul 12 18:26:03 2014 +0300 +++ b/Lib/test/test_tcl.py Sun Jul 13 19:21:55 2014 +0300 @@ -416,7 +416,7 @@

[issue21951] tcl test change crashes AIX

David Edelsohn added the comment: If I comment out all three tests, it runs. --- a/Lib/test/test_tcl.py Thu Jul 10 01:17:11 2014 -0400 +++ b/Lib/test/test_tcl.py Sat Jul 12 16:59:33 2014 -0700 @@ -455,9 +455,9 @@ check(float('inf'), 'Inf', eq=float_eq) check(-float('i

[issue21951] tcl test change crashes AIX

Serhiy Storchaka added the comment: Is it crashes when comment out "check((), '')"? Is it crashes when comment out two previous checks (for inf and -inf)? -- ___ Python tracker

[issue21951] tcl test change crashes AIX

Changes by Serhiy Storchaka : -- priority: normal -> high ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue21951] tcl test change crashes AIX

New submission from David Edelsohn: The patch for Issue #21881 causes CPython test_tcl to crash on AIX. $ ./python -m test -v test_tcl == CPython 3.5.0a0 (default:d1f89eb9ea1e+, Jul 10 2014, 10:21:22) [GCC 4.8.1] == AIX-1-00F84C0C4C00-powerpc-32bit big-endian == hash algorithm: siphash24 32b