[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Mathieu Dupuy added the comment: Much better indeed. Thanks. -- ___ Python tracker ___ ___ Python-bugs-list

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Berker Peksag added the comment: Thanks, Mathieu! I went with a simpler approach to test the code. -- keywords: -needs review nosy: +berker.peksag resolution: -> fixed stage: patch review -> resolved status: open -> closed type: enhancement -> behavior

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Roundup Robot added the comment: New changeset d135799e952b by Berker Peksag in branch '2.7': Issue #2202: Fix UnboundLocalError in AbstractDigestAuthHandler.get_algorithm_impls https://hg.python.org/cpython/rev/d135799e952b -- ___ Python tracker

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Roundup Robot added the comment: New changeset 22eab50cb585 by Berker Peksag in branch '3.5': Issue #2202: Fix UnboundLocalError in AbstractDigestAuthHandler.get_algorithm_impls https://hg.python.org/cpython/rev/22eab50cb585 New changeset 046c75c9cd33 by Berker Peksag in branch 'default':

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Mathieu Dupuy added the comment: I'm waiting for reviews. -- ___ Python tracker ___ ___ Python-bugs-list

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Mathieu Dupuy added the comment: first draft -- Added file: http://bugs.python.org/file42045/digest_md5sess_unittest.diff ___ Python tracker ___

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Mathieu Dupuy added the comment: I can see in the tests (test_urllib2_localnet.py) that Digest auth is tested only through "ProxyAuthTests". Is that sufficient ? Isn't it a bug ? If no, should I add the test in that class ? -- ___ Python tracker

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Martin Panter added the comment: I do wonder if NotImplementedError is the right exception. According to the documentation it is derived from RuntimeError and is meant for abstract methods, i.e. it is a programmer error. Other cases in urllib.request raise ValueError (e.g.

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Mathieu Dupuy added the comment: python 2.7 -- Added file: http://bugs.python.org/file41949/md5-sess_not_implem_27_v2.diff ___ Python tracker ___

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Mathieu Dupuy added the comment: python current -- Added file: http://bugs.python.org/file41950/md5-sess_not_implem_cur_v2.diff ___ Python tracker ___

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Mathieu Dupuy added the comment: up -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Changes by A.M. Kuchling a...@amk.ca: -- nosy: -akuchling ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2202 ___ ___ Python-bugs-list mailing

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Mathieu Dupuy added the comment: But I think md5-sess should really be integrated. It's a standard mechanism described by a RFC (https://www.ietf.org/rfc/rfc2617.txt), and people need it, however insecure it may be (aren't other method (md5) insecure too ?). --

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Mathieu Dupuy added the comment: and here for the 2.7 branch -- Added file: http://bugs.python.org/file36725/md5-sess_not_implem_27.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2202

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Mathieu Dupuy added the comment: here is the patch, for the trunk -- versions: -Python 3.4 Added file: http://bugs.python.org/file36724/md5-sess_not_implem_cur.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2202

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Mathieu Dupuy added the comment: Could we at least do something cleaner that let the interpreter raise an UnboundLocalError ? Maybe something like NotImplemented ? -- nosy: +deronnax ___ Python tracker rep...@bugs.python.org

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

R. David Murray added the comment: Sure. Would you like to propose a patch? It does seem that NotImplementedError would be the most appropriate. It could give Christian's reason why it is not implemented. -- stage: patch review - needs patch ___

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Changes by Mark Lawrence breamore...@yahoo.co.uk: -- nosy: -BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2202 ___ ___

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Christian Heimes added the comment: Python 3.3 has been released a while ago and is in bug fix mode. Personally I'm against this enhancement. It adds a digest auth scheme that is based on a broken and insecure hashing algorithm. -- nosy: +christian.heimes resolution: accepted - type:

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Chris Withers ch...@simplistix.co.uk added the comment: Who with and where does the argument need to be had? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2202 ___

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

R. David Murray rdmur...@bitdance.com added the comment: Hmm. How about python-committers? I would suggest python-dev, but that feels like invoking the dragon :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2202

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Chris Withers ch...@simplistix.co.uk added the comment: Hmm, I'd argue it's a bug: File /usr/lib64/python2.5/urllib2.py, line 972, in get_algorithm_impls return H, KD UnboundLocalError: local variable 'H' referenced before assignment ...does not say anything like: The digest

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

R. David Murray rdmur...@bitdance.com added the comment: Oh, the bad error message is definitely a bug. The question is whether we can also add md5-sess support while fixing it. Sounds like Senthil thinks no, in which case this issue needs to be split into two parts. --

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Chris Withers ch...@simplistix.co.uk added the comment: ...which is, of course, rather disappointing. When *would* md5-sess land? 2.7? 3.3?! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2202

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

R. David Murray rdmur...@bitdance.com added the comment: 3.3. IMO this is in the grey area between feature and bug fix. I think it is possible to argue that it can be treated as a bug fix, but I think we need opinions from other developers if we want to try to go that route. The reason I

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Chris Withers ch...@simplistix.co.uk added the comment: Just got bitten by this as well, what still needs to happen with the patch? -- keywords: -easy nosy: +cjw296 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2202

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

R. David Murray rdmur...@bitdance.com added the comment: One question is whether this is a bug fix or a feature request. Other than that, I'd like to see the test classes collapsed into a single test class, considering that each one only has a single test in it. Probably ProxyAuthTests

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Senthil Kumaran sent...@uthcode.com added the comment: Yes, it is a feature. Sorry that I have not paid attention to this. The Windows (IIS) part led me to delay as I did not have any to test. Let me take this up and see through it in 3.3. -- ___

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Kristján Valur Jónsson krist...@ccpgames.com added the comment: Is this moving anywhere? I was asked to apply this patch locally and am curious as to whether it is moving into the stdlib. -- nosy: +krisvale ___ Python tracker rep...@bugs.python.org

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Santoso Wijaya santoso.wij...@gmail.com added the comment: Adding some minor fixes to the original patch to apply cleanly to current 2.7 tip. Also, add a conditional branch in the case that the server returns none of the supported algorithm strings, to raise a ValueError (the previous patch

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Mark Lawrence breamore...@yahoo.co.uk added the comment: I tried to test the patch but got:- c:\Python26python.exe lib\test\test_urllib2_localnet.py Traceback (most recent call last): File lib\test\test_urllib2_localnet.py, line 325, in module class

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Changes by Senthil Kumaran orsent...@gmail.com: -- assignee: georg.brandl - orsenthil resolution: - accepted ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2202 ___

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Manuel Muradás mmura...@dieresys.com.ar added the comment: Here is a patch for supporting MD5-sess, following RFC2617 specification. Some comments/warnings: * I've only tested the patch against IIS 6.0. I don't know about other servers supporting MD5-sess. * IIS 6.0 expects the User Agent to

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Changes by Brian Curtin cur...@acm.org: -- keywords: +needs review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2202 ___ ___ Python-bugs-list

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Changes by Daniel Diniz aja...@gmail.com: -- nosy: +orsenthil stage: - test needed versions: -Python 2.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2202 ___

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Changes by Daniel Diniz aja...@gmail.com: -- nosy: +jjlee ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2202 ___ ___ Python-bugs-list mailing list

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Changes by Sean Reifschneider [EMAIL PROTECTED]: -- assignee: - georg.brandl nosy: +georg.brandl priority: - normal versions: +Python 2.6 __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2202 __

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

New submission from Brendan W. McAdams: URLLIB2 seems to have issues attempting to digest authenticate against a Windows-based IIS 6.x server. The IIS server requests MD5-sess support, and URLLIB2 throws an exception that ... far from explains this: Traceback (most recent call last): File

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

Brendan W. McAdams added the comment: Sorry, this isn't a crash. It doesn't crash the interpreter. I'll assume behavior' is the correct categorization. -- type: crash - behavior __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2202