[issue22090] Decimal and float formatting treat '%' differently for infinities and nans.

Change by Yoann Aubineau : -- nosy: -yaubi ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue22090] Decimal and float formatting treat '%' differently for infinities and nans.

R. David Murray added the comment: Yeah, right now that's fine. We'll work out the more strict process if/when we start actually enforcing it :) -- ___ Python tracker ___ _

[issue22090] Decimal and float formatting treat '%' differently for infinities and nans.

Stefan Krah added the comment: > I'm not going to argue this any further, but "recent" is exactly the > point...if all of the bots had turned red you'd understand that it needed to > be fixed *immediately* or the triggering change (regardless of what the > actual bug was) backed out. Since it

[issue22090] Decimal and float formatting treat '%' differently for infinities and nans.

R. David Murray added the comment: I'm not going to argue this any further, but "recent" is exactly the point...if all of the bots had turned red you'd understand that it needed to be fixed *immediately* or the triggering change (regardless of what the actual bug was) backed out. Since it isn

[issue22090] Decimal and float formatting treat '%' differently for infinities and nans.

Stefan Krah added the comment: The revisions that cause the bot to go red (6c468df214dc and 227ce85bdbe0) are quite recent, so I suggest we address the failure in #22285. -- ___ Python tracker _

[issue22090] Decimal and float formatting treat '%' differently for infinities and nans.

R. David Murray added the comment: Well, we have a goal of keeping the stable buildbots green. If something turns one or more red, it should either be fixed promptly, or the changeset that turned it red backed out until a fix is ready. The reason for keeping them green is so we know right awa

[issue22090] Decimal and float formatting treat '%' differently for infinities and nans.

Stefan Krah added the comment: I'm not sure that I understand. IMHO this issue does not break any buildbots. The current situation is that it exposes an unrelated import issue (#22280). I can camouflage that issue by upgrading the FreeBSD and the Fedora bot to libmpdec-2.4.1 (once it's out), but

[issue22090] Decimal and float formatting treat '%' differently for infinities and nans.

R. David Murray added the comment: (To be clear, I'm talking about the stable buildbots :) -- ___ Python tracker ___ ___ Python-bugs-l

[issue22090] Decimal and float formatting treat '%' differently for infinities and nans.

R. David Murray added the comment: As long as you have a plan to get the buildbots fixed in a timely fashion. -- ___ Python tracker ___ __

[issue22090] Decimal and float formatting treat '%' differently for infinities and nans.

Stefan Krah added the comment: It seems _decimal is imported even if _decimal.so is not built. I've opened #22280 for that. Regarding this patch, everything looks fine to me. -- status: open -> closed ___ Python tracker

[issue22090] Decimal and float formatting treat '%' differently for infinities and nans.

Stefan Krah added the comment: I think only the builders --with-system-libmpdec fail. That's inevitable, since they still use libmpdec-2.4.0. Starting from 7fbb912c0789 they should fail building _decimal entirely until I upgrade the system libmpdec on the builders. -- __

[issue22090] Decimal and float formatting treat '%' differently for infinities and nans.

R. David Murray added the comment: Looks like there is a bug of some sort, eg: http://buildbot.python.org/all/builders/AMD64%20Fedora%20without%20threads%203.4/builds/466 -- nosy: +r.david.murray status: closed -> open ___ Python tracker

[issue22090] Decimal and float formatting treat '%' differently for infinities and nans.

Changes by Stefan Krah : -- components: +Library (Lib) resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 2.7, Python 3.4 ___ Python tracker ___ _

[issue22090] Decimal and float formatting treat '%' differently for infinities and nans.

Roundup Robot added the comment: New changeset 5c585929658a by Stefan Krah in branch '3.4': Issue #22090: Fix '%' formatting for infinities and NaNs. http://hg.python.org/cpython/rev/5c585929658a New changeset 37ebb0d44808 by Stefan Krah in branch '2.7': Issue 22090: Fix '%' formatting for infin

[issue22090] Decimal and float formatting treat '%' differently for infinities and nans.

Stefan Krah added the comment: Thanks. I agree about 2.7 -- including 3.4 would perhaps make external libmpdec management easier for Debian and Arch. I'm not suggesting that we should always consider the distributors, but this particular issue seems so minor. -- __

[issue22090] Decimal and float formatting treat '%' differently for infinities and nans.

Mark Dickinson added the comment: The decimal.py part LGTM. (The rest looks good, too, but I haven't tested it.) This seems like one of those bugs that probably isn't worth backporting to 3.4, but given the projected longevity of 2.7 it might be worth applying there. --

[issue22090] Decimal and float formatting treat '%' differently for infinities and nans.

Stefan Krah added the comment: I guess it's the right thing to do and here's a patch. Could one of you double check the decimal.py part? -- keywords: +patch Added file: http://bugs.python.org/file36410/issue22090.diff ___ Python tracker

[issue22090] Decimal and float formatting treat '%' differently for infinities and nans.

Changes by Yoann Aubineau : -- nosy: +yaubi ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue22090] Decimal and float formatting treat '%' differently for infinities and nans.

Eric V. Smith added the comment: I agree that Decimal is wrong here. PEP 3101 says the result should include the trailing '%'. -- ___ Python tracker ___

[issue22090] Decimal and float formatting treat '%' differently for infinities and nans.

New submission from Mark Dickinson: There's a minor inconsistency between Decimal and float formatting for the `%` format type when handling infinities and nans: >>> from decimal import Decimal >>> format(float('inf'), '.2%') # includes trailing '%' 'inf%' >>> format(Decimal('inf'), '.2%') #