[issue22141] rlcompleter.Completer matches too much

Martin Panter added the comment: Maybe there are two special cases colliding here: 1. complete("A.foo", 0) returns "A.foo(". But the opening bracket is in readline.get_completer_delims(), which means the completer has suggested not only a “word” but also a delimiter. 2. Perhaps Lorenz has tak

[issue22141] rlcompleter.Completer matches too much

Changes by Robert Collins : -- stage: commit review -> patch review status: pending -> open ___ Python tracker ___ ___ Python-bugs-lis

[issue22141] rlcompleter.Completer matches too much

R. David Murray added the comment: I agree with Robert. You'll have to convince me that this is an actual bug. It seems reasonable to me that foobar would be returned in this case...it seems to me it is analogous to what my zsh shell does when I hit tab and there's no exact match but there i

[issue22141] rlcompleter.Completer matches too much

Robert Collins added the comment: I'm struggling to understand this bug. I've tried idle and plain cPython and neither exhibit it. I suspect thats due to how readline is itself tokenizing things. Python 3.6.0a0 (default:ef5a2ba9df62, Jul 28 2015, 15:48:19) [GCC 4.9.1] on linux Type "help", "c

[issue22141] rlcompleter.Completer matches too much

Lorenz Quack added the comment: sorry it took so long but the contributor agreement is now signed. -- ___ Python tracker ___ ___ Pytho

[issue22141] rlcompleter.Completer matches too much

Claudiu Popa added the comment: Looks good to me. You might want to sign the contributor agreement: https://www.python.org/psf/contrib/contrib-form/. This is required for non-trivial contributions. You'll get a * next to your name after signing it. -- stage: patch review -> commit revi

[issue22141] rlcompleter.Completer matches too much

Changes by Lorenz Quack : Added file: http://bugs.python.org/file37064/rlcompleter_22141.patch ___ Python tracker ___ ___ Python-bugs-list mai

[issue22141] rlcompleter.Completer matches too much

Changes by Lorenz Quack : Removed file: http://bugs.python.org/file37063/rlcompleter_22141.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue22141] rlcompleter.Completer matches too much

Lorenz Quack added the comment: sorry for the delay but here is a new patch with a test. I changed the strategy for fixing the bug because the dealing with the opening parenthesis became to complicated. So, now I simply check whether the match actually startswith the search phrase before addi

[issue22141] rlcompleter.Completer matches too much

Lorenz Quack added the comment: Oops! tests sound like a good Idea. I realized my "fix" doesn't work. I had not noticed this before because in my application I had already implemented a workaround :/ The problem with catching the trailing parenthesis is that the group then does not match the

[issue22141] rlcompleter.Completer matches too much

Claudiu Popa added the comment: Looks good. Could you add a test that reproduces the intended behaviour? -- nosy: +Claudiu.Popa ___ Python tracker ___ ___

[issue22141] rlcompleter.Completer matches too much

Changes by Terry J. Reedy : -- stage: -> patch review versions: -Python 3.1, Python 3.2, Python 3.3 ___ Python tracker ___ ___ Pytho

[issue22141] rlcompleter.Completer matches too much

Lorenz Quack added the comment: attached the mini patch changing the regular expression in the proposed way -- keywords: +patch Added file: http://bugs.python.org/file36269/rlcompleter.diff ___ Python tracker _

[issue22141] rlcompleter.Completer matches too much

New submission from Lorenz Quack: Example: >>> completer = rlcompleter.Completer() >>> class A(object): ... def foo(): pass ... def foobar(): pass >>> completer.complete("A.foo(", 0) 'A.foo(' >>> completer.complete("A.foo(", 1) 'A.foobar(' I consider the last match a bug. The root of