[issue2222] Memory leak in os.rename?

Hirokazu Yamamoto [EMAIL PROTECTED] added the comment: Fixed in r65745. Will be backported to py3k and release25-maint. -- resolution: - fixed status: open - closed ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue

[issue2222] Memory leak in os.rename?

Hirokazu Yamamoto [EMAIL PROTECTED] added the comment: Backported to py3k(r65746) release25-maint(r65747) ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue ___

[issue2222] Memory leak in os.rename?

Changes by Hirokazu Yamamoto [EMAIL PROTECTED]: ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue2222] Memory leak in os.rename?

Benjamin Peterson [EMAIL PROTECTED] added the comment: How's this coming along? -- nosy: +benjamin.peterson ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue ___

[issue2222] Memory leak in os.rename?

Changes by Hirokazu Yamamoto [EMAIL PROTECTED]: -- components: +Windows -Extension Modules __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue __ ___ Python-bugs-list

[issue2222] Memory leak in os.rename?

Changes by Neal Norwitz [EMAIL PROTECTED]: -- priority: normal - critical __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue __ ___ Python-bugs-list mailing list

[issue2222] Memory leak in os.rename?

Hirokazu Yamamoto [EMAIL PROTECTED] added the comment: I reimplemented patch without O, and made test for all platforms. Unfortunately Windows doesn't have os.link and os.symlink, so for os.rename only. Added file: http://bugs.python.org/file10077/test_and_fix.patch

[issue2222] Memory leak in os.rename?

Changes by Sean Reifschneider [EMAIL PROTECTED]: -- priority: - normal __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue __ ___ Python-bugs-list mailing list

[issue2222] Memory leak in os.rename?

Hirokazu Yamamoto added the comment: Alexander, I've looked into Python/getargs.c, I think posix_2str code is fine. (PyArg_ParseTuple with format et) After conversion succeeded on path1, addcleanup() adds memory buffer for path1 into freelist. When error happend on path2, its memory will be

[issue2222] Memory leak in os.rename?

Alexander Belopolsky added the comment: Aha! I did not know about the cleanup. Maybe that should be documented as well. This shows that using O with a converter returning a PyObject* is a bad idea. (General clean-up is not possible for O because there is no way to tell what type the

[issue2222] Memory leak in os.rename?

Alexander Belopolsky added the comment: The affected code is the only case I could find in stdlib where O format was used to populate PyObject* variables. Although it appears to be valid usage, the code presents an exception to the following note at http://docs.python.org/dev/c-api/arg.html

[issue2222] Memory leak in os.rename?

New submission from Hirokazu Yamamoto: Hello. Probably I found memory leak. When first convert_to_unicode succeeds and second one fails, first unicode object is not freed. # ex: os.rename(a, 3) Thank you. -- components: Extension Modules files: fix_leak.patch keywords: patch messages:

[issue2222] Memory leak in os.rename?

Hirokazu Yamamoto added the comment: I cannot write patch to use gc.set_debug(gc.DEBUG_LEAK), so I tried regrtest.py -R :: instead. (This functionality is not working now, so I tried after reverted r61098) E:\python-dev\trunk\Lib\testpy regrtest.py -R :: test_os.py test_os beginning 9