Changes by Berker Peksag berker.pek...@gmail.com:
--
stage: patch review - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22278
___
___
Martin Panter added the comment:
I opened Issue 23703 for a regression caused by this commit.
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22278
___
Senthil Kumaran added the comment:
I addressed Antoine's comments with the patch and committed it. Thank you!
--
assignee: - orsenthil
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 901e4e52b20a by Senthil Kumaran in branch 'default':
Issue #22278: Fix urljoin problem with relative urls, a regression observed
https://hg.python.org/cpython/rev/901e4e52b20a
--
nosy: +python-dev
___
Demian Brecht added the comment:
Heh, I'd finally gotten a few minutes to address the comments... And it's
already taken care of ;) Thanks Senthil.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22278
Senthil Kumaran added the comment:
Except for the minor comments made by Antoine in the review, the patch looks
good to go.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22278
___
Demian Brecht added the comment:
Antoine: On (finally) getting back to this and re-reading your test case, the
current behaviour is incorrect and is corrected by the patch. I've added a few
more test cases to ensure trailing slashes are handled correctly.
--
Added file:
Antoine Pitrou added the comment:
Those tests don't seem to bring much. Part of them are straight from the RFC
(and therefore already in the current test suite, I assume), part of them are
for non-HTTP protocols such as fred (!). A couple of them seem to be genuine,
although only one fails
Demian Brecht added the comment:
I'll try to get some time this week to extend the various test cases, thanks
for pointing that out Antoine.
I also found that, other than the few RFC-specific blocks in the link that Nick
added in the other ticket, not only were they questionable (non-HTTP as
Antoine Pitrou added the comment:
This patch seems to fix issue #22311 as well (*). However it would be good to
add more tests for base URLs with trailing slashes, it seems.
(*) without patch:
base = https://pypi.python.org/simple/werkzeug/;
rel =
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +scoder
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22278
___
___
Python-bugs-list mailing
Stefan Behnel added the comment:
Were the tests in
http://bugs.python.org/file32591/urischemes.py
merged yet, that Nick Coghlan mentioned in
http://bugs.python.org/issue22118#msg225662 ?
--
___
Python tracker rep...@bugs.python.org
New submission from Demian Brecht:
Reported by Stefan Behnel in issue22118:
I'm now getting duplicated slashes in URLs, e.g.:
https://new//foo.html
http://my.little.server/url//logo.gif
In both cases, the base URL that gets joined with the postfix had a trailing
slash, e.g.
Changes by Demian Brecht demianbre...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file36479/issue22278.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22278
___
Changes by Ned Deily n...@acm.org:
--
nosy: +orsenthil, pitrou
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22278
___
___
15 matches
Mail list logo
