[issue22438] eventlet broke by python 2.7.x

Nick Coghlan added the comment: Just noting that if we decided to reconsider addressing this upstream for the benefit of folks backporting PEP 493, Robert Kuska wrote a patch to restore sslwrap for the RHEL/CentOS PEP 466 backport: * https://git.centos.org/blob/rpms!python.git/f63228654ecef84

[issue22438] eventlet broke by python 2.7.x

Alex Gaynor added the comment: FWIW, that code is all significantly simplified by the patch in http://bugs.python.org/issue22559 -- ___ Python tracker ___ __

[issue22438] eventlet broke by python 2.7.x

Marc-Andre Lemburg added the comment: Looking at recent comments on the gevent ticket, the 2.7.9 changes are already causing problems for people since apparently the changes were backported to 2.7.8 by some vendors. https://github.com/gevent/gevent/issues/477 -- ___

[issue22438] eventlet broke by python 2.7.x

Marc-Andre Lemburg added the comment: On 07.11.2014 13:12, Antoine Pitrou wrote: > > It's not a mere matter of putting back the code... The 3.x ssl implementation > which was backported uses a slightly different approach from the 2.x > implementation, so it's not obvious we can recreate an ent

[issue22438] eventlet broke by python 2.7.x

Antoine Pitrou added the comment: It's not a mere matter of putting back the code... The 3.x ssl implementation which was backported uses a slightly different approach from the 2.x implementation, so it's not obvious we can recreate an entirely compatible implementation of_ssl.sslwrap(). As a

[issue22438] eventlet broke by python 2.7.x

Arfrever Frehtes Taifersar Arahesis added the comment: > Hmm, even though the API is still there, it uses _ssl.sslwrap() as > well, so it won't work anymore either. It was fixed in bug #22523. -- ___ Python tracker

[issue22438] eventlet broke by python 2.7.x

Marc-Andre Lemburg added the comment: On 07.11.2014 12:49, Marc-Andre Lemburg wrote: >> BTW: The sslwrap_simple() API was also removed in 2.7.9. > > Scratch that. I was in the wrong work dir :-) Hmm, even though the API is still there, it uses _ssl.sslwrap() as well, so it won't work anymore ei

[issue22438] eventlet broke by python 2.7.x

Marc-Andre Lemburg added the comment: On 07.11.2014 11:30, Marc-Andre Lemburg wrote: > BTW: The sslwrap_simple() API was also removed in 2.7.9. Scratch that. I was in the wrong work dir :-) -- ___ Python tracker _

[issue22438] eventlet broke by python 2.7.x

Arfrever Frehtes Taifersar Arahesis added the comment: Monkey-patching is as supported as using private API. Maintainers of third-party projects monkey-patching something or using private API should expect to sporadically have to adjust their projects to new Python versions. -- __

[issue22438] eventlet broke by python 2.7.x

Marc-Andre Lemburg added the comment: On 07.11.2014 11:52, Arfrever Frehtes Taifersar Arahesis wrote: > > Arfrever Frehtes Taifersar Arahesis added the comment: > >> No, the use of the underscore in _ssl is per convention that C >> implementation part of stdlib modules are moved into modules th

[issue22438] eventlet broke by python 2.7.x

Arfrever Frehtes Taifersar Arahesis added the comment: > No, the use of the underscore in _ssl is per convention that C > implementation part of stdlib modules are moved into modules that > start with an underscore. This doesn't mean that the APIs in > those modules are private, otherwise many C

[issue22438] eventlet broke by python 2.7.x

Marc-Andre Lemburg added the comment: On 07.11.2014 11:12, Arfrever Frehtes Taifersar Arahesis wrote: > > Arfrever Frehtes Taifersar Arahesis added the comment: > > _ssl has leading underscore. > Privateness is "inherited", so both A._B.C and A._B._D are private. No, the use of the underscore

[issue22438] eventlet broke by python 2.7.x

Arfrever Frehtes Taifersar Arahesis added the comment: _ssl has leading underscore. Privateness is "inherited", so both A._B.C and A._B._D are private. -- ___ Python tracker ___

[issue22438] eventlet broke by python 2.7.x

Marc-Andre Lemburg added the comment: Even though it may have been considered a private API (*), users certainly won't understand that their application just broke because of a Python patch level release upgrade, so if possible, I think the API should be added back and flagged as "private, but

[issue22438] eventlet broke by python 2.7.x

Arfrever Frehtes Taifersar Arahesis added the comment: Private API is expected to be allowed to be deleted or incompatibly changed in any micro release. -- ___ Python tracker __

[issue22438] eventlet broke by python 2.7.x

Denis Bilenko added the comment: gevent's ssl support is also broken by 2.7.9. https://github.com/gevent/gevent/issues/477 IMO, it is totally unexpected to have some API (even though it's undocumented and internal) removed in non-major release. Even though both gevent and eventlet can be fixe

[issue22438] eventlet broke by python 2.7.x

Benjamin Peterson added the comment: Definitely a case of eventlet playing with fire (private apis). -- resolution: -> not a bug status: open -> closed ___ Python tracker ___ __

[issue22438] eventlet broke by python 2.7.x

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue22438] eventlet broke by python 2.7.x

Barry A. Warsaw added the comment: I tend to agree. I don't even think it was documented. I wonder though if it makes sense to at least mention this in the PEP and/or release notes for 2.7.9. -- ___ Python tracker

[issue22438] eventlet broke by python 2.7.x

Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue22438] eventlet broke by python 2.7.x

Antoine Pitrou added the comment: Certainly not an official API anyway. Let eventlet get their stuff straight. -- ___ Python tracker ___ _

[issue22438] eventlet broke by python 2.7.x

Alex Gaynor added the comment: (It didn't have any direct tests as far as I can tell, which is why I didn't catch the "regression") -- ___ Python tracker ___ ___

[issue22438] eventlet broke by python 2.7.x

Alex Gaynor added the comment: It looks like something was removed from the `_ssl` module; is that considered an implementation detail, or does it need to be added back? -- ___ Python tracker _

[issue22438] eventlet broke by python 2.7.x

New submission from Alex Gaynor: https://github.com/eventlet/eventlet/issues/135 -- components: Library (Lib) messages: 227067 nosy: alex, benjamin.peterson, christian.heimes, dstufft, giampaolo.rodola, janssen, pitrou priority: normal severity: normal status: open title: eventlet broke