[issue22637] avoid using a shell in uuid: replce os.popen with subprocess.Popen

2014-10-14 Thread STINNER Victor
New submission from STINNER Victor: Attached patch modifies the uuid module to not use a shell: it replaces os.popen() with subprocess.Popen on UNIX. Running a shell is slower and is more vulnerable to code injection. I only modified code path on UNIX right now. They is still a call to os.pope

[issue22637] avoid using a shell in uuid: replce os.popen with subprocess.Popen

2014-10-14 Thread Josh Rosenberg
Changes by Josh Rosenberg : -- nosy: +josh.r ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue22637] avoid using a shell in uuid: replce os.popen with subprocess.Popen

2014-10-14 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue22637] avoid using a shell in uuid: replce os.popen with subprocess.Popen

2014-10-15 Thread STINNER Victor
STINNER Victor added the comment: Arfrever wrote me on IRC: > Your patch for issue #22637 has print(executable) Ooops. Updated patch without the print. -- Added file: http://bugs.python.org/file36930/uuid_popen-2.patch ___ Python tracker

[issue22637] avoid using a shell in uuid: replce os.popen with subprocess.Popen

2014-10-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Besides few nitpicks the patch LGTM. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-

[issue22637] avoid using a shell in uuid: replce os.popen with subprocess.Popen

2014-10-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8ee63d0bd7b8 by Victor Stinner in branch 'default': Issue #22637: avoid using a shell in uuid https://hg.python.org/cpython/rev/8ee63d0bd7b8 -- nosy: +python-dev ___ Python tracker

[issue22637] avoid using a shell in uuid: replce os.popen with subprocess.Popen

2014-10-22 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue22637] avoid using a shell in uuid: replce os.popen with subprocess.Popen

2014-11-05 Thread Roundup Robot
Roundup Robot added the comment: New changeset 16d6c2443131 by Victor Stinner in branch 'default': Issue #22793, #22637: Add missing "import os" in uuid._ifconfig_getnode() https://hg.python.org/cpython/rev/16d6c2443131 -- ___ Python tracker