[issue22674] RFE: Add signal.strsignal(): string describing a signal

Antoine Pitrou added the comment: New changeset 019f5b3e9e4c2a1297580483c3d5a5a10bddb93b by Antoine Pitrou (Antoine Pietri) in branch 'master': bpo-22674: fix test_strsignal on OSX (GH-6085) https://github.com/python/cpython/commit/019f5b3e9e4c2a1297580483c3d5a5a10bddb93b

[issue22674] RFE: Add signal.strsignal(): string describing a signal

Change by Antoine Pitrou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue22674] RFE: Add signal.strsignal(): string describing a signal

Ned Deily added the comment: > Ned, this is why I'd like issue33048 to be solved :-) Having to rely on the > buildbot fleet for bugfix iteration is not convenient at all. I want to see it solved, too. :-) But there are other core-devs out there who are in a better position

[issue22674] RFE: Add signal.strsignal(): string describing a signal

Antoine Pietri added the comment: Done, https://github.com/python/cpython/pull/6085 As I said in the PR body, I can't test it myself, I don't have an OSX VM setup. -- ___ Python tracker

[issue22674] RFE: Add signal.strsignal(): string describing a signal

Change by Antoine Pietri : -- pull_requests: +5846 stage: needs patch -> patch review ___ Python tracker ___

[issue22674] RFE: Add signal.strsignal(): string describing a signal

Antoine Pitrou added the comment: > Should I submit a new PR for this? Please do. -- ___ Python tracker ___

[issue22674] RFE: Add signal.strsignal(): string describing a signal

Antoine Pietri added the comment: Yes, sorry, the issue is that we decided with pitrou to remove the osx specific handling. The fix should be: diff --git a/Lib/test/test_signal.py b/Lib/test/test_signal.py index fbb12a5b67..ae0351e992 100644 ---

[issue22674] RFE: Add signal.strsignal(): string describing a signal

Antoine Pitrou added the comment: Ned, this is why I'd like issue33048 to be solved :-) Having to rely on the buildbot fleet for bugfix iteration is not convenient at all. -- ___ Python tracker

[issue22674] RFE: Add signal.strsignal(): string describing a signal

Ned Deily added the comment: test_strsignal is failing on macOS. == FAIL: test_strsignal (test.test_signal.PosixTests) -- Traceback (most

[issue22674] RFE: Add signal.strsignal(): string describing a signal

Antoine Pitrou added the comment: This is now pushed. Thank you Antoine! -- nosy: +pitrou ___ Python tracker ___

[issue22674] RFE: Add signal.strsignal(): string describing a signal

Change by Antoine Pitrou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8 -Python 3.5 ___ Python tracker

[issue22674] RFE: Add signal.strsignal(): string describing a signal

Antoine Pietri added the comment: I updated Vajrasky's patch to rebase it onto master, use the clinic argument parser and improve the docs. I made a PR on GitHub so the review can be easier than a patch. I left a Co-Authored-By field so I'm not stealing the

[issue22674] RFE: Add signal.strsignal(): string describing a signal

Change by Antoine Pietri : -- pull_requests: +5784 stage: -> patch review ___ Python tracker ___

[issue22674] RFE: Add signal.strsignal(): string describing a signal

Change by Chris Rebert : -- nosy: +cvrebert ___ Python tracker ___ ___

[issue22674] RFE: Add signal.strsignal(): string describing a signal

STINNER Victor added the comment: > 3. For the unknown signal, what is the description should be? "Unknown > signal" like c function returns or None? Hum, Linux returns "Unknown signal 12345". I propose to use this behaviour on all platforms (which provide