[issue22751] Fix test___all__ warning about modified environment

Ezio Melotti added the comment: The buildbot seems happy, so I'm going to close this. Thanks for the patch! -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker __

[issue22751] Fix test___all__ warning about modified environment

Roundup Robot added the comment: New changeset 37ed6eed0595 by Ezio Melotti in branch '3.4': #22751: fix test___all__ warning about modified environment in the tests. Patch by Michael Cetrulo. https://hg.python.org/cpython/rev/37ed6eed0595 New changeset 16dfefe67c1f by Ezio Melotti in branch '

[issue22751] Fix test___all__ warning about modified environment

Zachary Ware added the comment: It doesn't look like "import locale" can fail ("import _locale" can, but locale.py has emulation that would work with this patch). LGTM. -- stage: patch review -> commit review versions: -Python 3.6 ___ Python tracke

[issue22751] Fix test___all__ warning about modified environment

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue22751] Fix test___all__ warning about modified environment

Ezio Melotti added the comment: Are there cases where "import locale" might fail? If so, it should maybe be moved in the try, otherwise the patch LGTM. -- assignee: -> ezio.melotti nosy: +serhiy.storchaka, zach.ware stage: -> patch review ___ Python

[issue22751] Fix test___all__ warning about modified environment

Changes by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue22751] Fix test___all__ warning about modified environment

New submission from Michael Cetrulo: The following warning is being generated when running test case: Warning -- locale was modified by test___all__ According to the comment there, importing the rlcompleter module changes (or used to change) the locale so after the import it was being set to