Robert Collins added the comment:
This itself is fixed.
--
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22936
___
Changes by R. David Murray rdmur...@bitdance.com:
--
nosy: +n
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22936
___
___
Python-bugs-list mailing
Robert Collins added the comment:
And the unittest patch.
--
Added file: http://bugs.python.org/file38348/issue-22936-5.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22936
___
Changes by Robert Collins robe...@robertcollins.net:
Added file: http://bugs.python.org/file38349/issue-22936-5.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22936
___
Robert Collins added the comment:
No worries. BTW there is one more patch needed to close this issue - adding the
feature to unittest. I'm working that up now.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22936
Changes by Robert Collins robe...@robertcollins.net:
Removed file: http://bugs.python.org/file38348/issue-22936-5.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22936
___
Changes by Guido van Rossum gu...@python.org:
--
nosy: -gvanrossum
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22936
___
___
Python-bugs-list
Mark Lawrence added the comment:
msg237320 ...so I'm *NOT* entirely convinced...? :)
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22936
___
Ezio Melotti added the comment:
In the patch you made some args kw-only.
Isn't that backward incompatible in case someone was passing them by position?
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22936
Nick Coghlan added the comment:
It's only the new APIs just introduced in issue #17911 that changed to kwonly
arguments.
We missed that they should really be kwonly in the original review, but it
become more obvious in this patch, as it added a second feature toggle to
indicate whether or
Ezio Melotti added the comment:
You are right -- I didn't notice the versionadded in the docs.
Sorry for the noise.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22936
___
Roundup Robot added the comment:
New changeset b4a26b28f5b3 by Robert Collins in branch 'default':
Issue #22936: Allow showing local variables in unittest errors.
https://hg.python.org/cpython/rev/b4a26b28f5b3
--
___
Python tracker
Nick Coghlan added the comment:
I just filed issue #23597 as a potential further follow-up to this, which would
be to also add support for displaying local variables directly to the logging
module.
However, that has some additional security implications, so I'm entirely
convinced it's a good
Changes by Robert Collins robe...@robertcollins.net:
Removed file: http://bugs.python.org/file38332/issue-22936-3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22936
___
Changes by Robert Collins robe...@robertcollins.net:
Added file: http://bugs.python.org/file38333/issue-22936-3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22936
___
Changes by Robert Collins robe...@robertcollins.net:
Added file: http://bugs.python.org/file38336/issue-22936-4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22936
___
Robert Collins added the comment:
And now updated to HEAD as 17911 has been committed.
--
Added file: http://bugs.python.org/file38332/issue-22936-3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22936
Nick Coghlan added the comment:
Latest patch (issue-22936-4.patch) looks good to me!
--
nosy: +ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22936
___
Roundup Robot added the comment:
New changeset 50741316dd3a by Robert Collins in branch 'default':
Issue #22936: Make it possible to show local variables in tracebacks.
https://hg.python.org/cpython/rev/50741316dd3a
--
nosy: +python-dev
___
Python
Robert Collins added the comment:
updated with the latest 17911 patch basis.
--
Added file: http://bugs.python.org/file38008/issue-22936-2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22936
Robert Collins added the comment:
First cut implementation. I'm sure there is lots we can add, but this will make
things nicer in and of itself.
Thanks for the pointer to cgitb, I've skimmed it and its definitely much more
comprehensive. I'm not entirely sure about the best way to glue it and
Changes by Chris Rebert pyb...@rebertia.com:
--
nosy: +cvrebert
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22936
___
___
Python-bugs-list
Guido van Rossum added the comment:
Check out the cgitb stdlib module.
--
nosy: +gvanrossum
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22936
___
New submission from Robert Collins:
From https://github.com/testing-cabal/testtools/issues/111 - any code that is
data dependent can be hard to diagnose from a backtrace alone. Many unittest
and server environments address this by doing custom tracebacks that include
locals.
To address this
Changes by Robert Collins robe...@robertcollins.net:
--
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22936
___
___
Robert Collins added the comment:
See http://bugs.python.org/issue22936 for the unittest aspect of this.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22936
___
26 matches
Mail list logo
