[issue22970] asyncio: Cancelling wait() after notification leaves Condition in an inconsistent state

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing

[issue22970] asyncio: Cancelling wait() after notification leaves Condition in an inconsistent state

Yury Selivanov added the comment: I'm merging David's patch. I concur with David that the only viable way to fix this is to loop through the CancelledError until the lock is acquired (and Condition is in a right state). Thanks, David. It should make it to 3.5.2 now. -- resolution:

[issue22970] asyncio: Cancelling wait() after notification leaves Condition in an inconsistent state

Roundup Robot added the comment: New changeset 0bda9bc443ce by Yury Selivanov in branch '3.5': Issue #22970: asyncio: Fix inconsistency cancelling Condition.wait. https://hg.python.org/cpython/rev/0bda9bc443ce New changeset 00a9de0f3fdc by Yury Selivanov in branch 'default': Merge 3.5 (issue

[issue22970] asyncio: Cancelling wait() after notification leaves Condition in an inconsistent state

David Coles added the comment: Please find the PR including a test to reproduce the issue here: https://github.com/python/asyncio/pull/346 -- ___ Python tracker

[issue22970] asyncio: Cancelling wait() after notification leaves Condition in an inconsistent state

David Coles added the comment: Hi Yury, Sure - I'll create a PR along with a test that reproduces the issue. Should be able to get that done this weekend. -- ___ Python tracker

[issue22970] asyncio: Cancelling wait() after notification leaves Condition in an inconsistent state

Yury Selivanov added the comment: Hi David, thanks for working on this issue. Your patch and reasoning behind it looks correct, but it's hard to say that definitively without tests and full code review. Could you please submit a PR to https://github.com/python/asyncio (upstream for asyncio)

[issue22970] asyncio: Cancelling wait() after notification leaves Condition in an inconsistent state

Yury Selivanov added the comment: OK, I'll see what I can do (this is some code that I don't know/use). -- ___ Python tracker ___

[issue22970] asyncio: Cancelling wait() after notification leaves Condition in an inconsistent state

Guido van Rossum added the comment: Yury can you take this on? -- assignee: -> yselivanov ___ Python tracker ___

[issue22970] asyncio: Cancelling wait() after notification leaves Condition in an inconsistent state

David Coles added the comment: Since I reported this, I haven't seen any proposed solutions other other than a retry loop to ensure that the lock is guaranteed to be reacquired when the sleeping coroutine is woken. The four possibilities of cancelling the waiting coroutine are: 1. Before

[issue22970] asyncio: Cancelling wait() after notification leaves Condition in an inconsistent state

Guido van Rossum added the comment: Presumably. :-( -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue22970] asyncio: Cancelling wait() after notification leaves Condition in an inconsistent state

Ned Deily added the comment: Is this still a Release Blocker for 3.6? -- nosy: +ned.deily ___ Python tracker ___

[issue22970] asyncio: Cancelling wait() after notification leaves Condition in an inconsistent state

Guido van Rossum added the comment: (It could be fixed in 3.5.1, since asyncio is still provisional in 3.5.) -- ___ Python tracker ___

[issue22970] asyncio: Cancelling wait() after notification leaves Condition in an inconsistent state

Larry Hastings added the comment: Reassigning to 3.6. -- priority: deferred blocker -> release blocker versions: +Python 3.6 -Python 3.4, Python 3.5 ___ Python tracker

[issue22970] asyncio: Cancelling wait() after notification leaves Condition in an inconsistent state

STINNER Victor added the comment: asyncio keeps its "provisional API" status in the Python 3.5 cycle, so this issue must not block the 3.5.0 release. It can be fixed later. This issue is complex, I'm not convinced that asyncio-fix-wait-cancellation-race.patch is the best fix. --

[issue22970] asyncio: Cancelling wait() after notification leaves Condition in an inconsistent state

Larry Hastings added the comment: Is anyone going to try and fix this for 3.5.0? Or should we "kick the can down the road" and reassign it to 3.6? -- nosy: +larry ___ Python tracker

[issue22970] asyncio: Cancelling wait() after notification leaves Condition in an inconsistent state

Changes by Yury Selivanov yseliva...@gmail.com: -- priority: normal - deferred blocker ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22970 ___ ___

[issue22970] asyncio: Cancelling wait() after notification leaves Condition in an inconsistent state

Changes by STINNER Victor victor.stin...@gmail.com: -- title: Cancelling wait() after notification leaves Condition in an inconsistent state - asyncio: Cancelling wait() after notification leaves Condition in an inconsistent state ___ Python