Serhiy Storchaka added the comment:
Thanks for your outsight Arfrever.
--
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22977
Roundup Robot added the comment:
New changeset 5cc0a090829a by Serhiy Storchaka in branch '3.4':
Issue #22977: Remove unconditional import of ctypes.
https://hg.python.org/cpython/rev/5cc0a090829a
New changeset f46454229cf5 by Serhiy Storchaka in branch 'default':
Issue #22977: Remove
Arfrever Frehtes Taifersar Arahesis added the comment:
Unconditional 'import ctypes' in Lib/test/test_exceptions.py was not yet
deleted.
--
nosy: +Arfrever
resolution: fixed -
stage: resolved -
status: closed - open
___
Python tracker
STINNER Victor added the comment:
Oh, and the ctypes module (import) must be optional, just skip the test if
ctypes is missing.
http://buildbot.python.org/all/builders/AMD64%20OpenIndiana%203.x/builds/9555/steps/test/logs/stdio
test test_exceptions crashed -- Traceback (most recent call
Roundup Robot added the comment:
New changeset 7907746baa0d by Serhiy Storchaka in branch '3.4':
Issue #22977: Fixed formatting Windows error messages on Wine.
https://hg.python.org/cpython/rev/7907746baa0d
New changeset cf0cac11813d by Serhiy Storchaka in branch 'default':
Issue #22977: Fixed
STINNER Victor added the comment:
On Python 3.4, windll.kernel32.RaiseException(2, 0, 0, None) raised a
FileNotFound error.
On Python 3.5, it displays a popup and the program exit.
It looks like the behaviour of RaiseException() changed in Python 3.5. I tested
in debug and release mode.
Serhiy Storchaka added the comment:
Yes, you are right.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22977
___
___
Python-bugs-list mailing
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22977
___
Martin Panter added the comment:
I don’t pretend to know what is going on, or the best way to fix it. That exit
code is the same code that my test passes to RaiseException. Perhaps it would
be best to disable the test until someone with more knowledge or a Windows
compiler can investigate.
STINNER Victor added the comment:
I'm not sure that Windows appreciate your change :-)
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/6011/steps/test/logs/stdio
[216/393] test_exceptions
Traceback (most recent call last):
File
Serhiy Storchaka added the comment:
Could you provide a patch if you can test it Victor?
--
assignee: serhiy.storchaka -
stage: resolved - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22977
Martin Panter added the comment:
Thanks for fixing the test Victor. The ctypes.pythonapi trick looks like a much
better way. :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22977
___
Roundup Robot added the comment:
New changeset dafae2b3c257 by Victor Stinner in branch '3.4':
Issue #22977: Fix test_exceptions
https://hg.python.org/cpython/rev/dafae2b3c257
--
___
Python tracker rep...@bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: needs patch - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22977
___
Martin Panter added the comment:
All the other occurrences of capitalized %X that I can find are not using
Python’s string formatting functions. Please point them out if you can, but all
I can see are some using a Microsoft vfwprintf_s() API, some calling standard C
sprintf(), sscanf(),
Serhiy Storchaka added the comment:
LGTM.
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22977
___
___
Serhiy Storchaka added the comment:
There are other occurrences of %X in the code. Do you want provide a patch for
them Martin?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22977
___
Martin Panter added the comment:
V3 patch with suggested changes to the test case, though still completely
untested by me.
--
Added file: http://bugs.python.org/file38641/win-error-format-v3.patch
___
Python tracker rep...@bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22977
___
STINNER Victor added the comment:
The attached patch lacks an unit test. When I will be able to build CPython
again, I will try the patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22977
Changes by Berker Peksag berker.pek...@gmail.com:
--
stage: - patch review
versions: +Python 3.4, Python 3.5 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22977
___
Martin Panter added the comment:
This patch includes a test case, based on Eryksun’s exception code
--
Added file: http://bugs.python.org/file37686/win-error-format-v2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22977
Martin Panter added the comment:
Here’s a simple patch which should fix it, although I have not verified this
because I don’t have a Windows compiler (and MINGW cross compiling sounds too
tricky)
--
keywords: +patch
Added file: http://bugs.python.org/file37678/win-error-format.patch
Changes by STINNER Victor victor.stin...@gmail.com:
--
title: Unformatted “Windows Error 0x%X” exception message - Unformatted
“Windows Error 0x%X” exception message on Wine
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22977
24 matches
Mail list logo
